Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in airGapped mode, ensure that the desired k8s version is used #297

Closed
tmmorin opened this issue Apr 2, 2024 · 1 comment · Fixed by #319
Closed

in airGapped mode, ensure that the desired k8s version is used #297

tmmorin opened this issue Apr 2, 2024 · 1 comment · Fixed by #319
Assignees
@Danil-Grigorev
Labels
area/bootstrap Indicates an issue or PR related to the bootstrap provider kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tmmorin
Copy link

tmmorin commented Apr 2, 2024

We noticed while developing Sylva that, in airGapped mode (spec.agentConfig.airGapped: true), the combination of RKE2 bootstrap provider and RK2 itself will result in using _whatever version of RKE2 is present in /opt/rke2-artifacts, even if this version does not match spec.agentConfig.version.

It creates a risk of unintendedly using an undesired version, and possibly unintendedly upgrading or downgrading, if the OS image is not selected carefully.

A safer behavior for air-gapped mode would be to abort RKE2 installation if the RKE2 version that can be found on disk does not match spec.agentConfig.version.

/cc @richardcase
@tmmorin tmmorin added kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 2, 2024
@tmmorin tmmorin changed the title ensure that even in airGapped mode, the desired k8s version is used in airGapped mode, ensure that the desired k8s version is used Apr 2, 2024
@richardcase richardcase added area/bootstrap Indicates an issue or PR related to the bootstrap provider priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 3, 2024
@richardcase
Copy link
Contributor

Thank you @tmmorin

@Danil-Grigorev Danil-Grigorev mentioned this issue May 2, 2024
Closed
@Danil-Grigorev Danil-Grigorev mentioned this issue May 10, 2024
Merged
4 tasks
@Danil-Grigorev Danil-Grigorev self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danil-Grigorev Danil-Grigorev

Labels
area/bootstrap Indicates an issue or PR related to the bootstrap provider kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@richardcase @tmmorin @Danil-Grigorev