Add airGappedChecksum field to check workload version before rollout #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
added
kind/feature
alexander-demicev
previously approved these changes
May 13, 2024
| // AirGappedChecksum is a string value with a sha256sum checksum to compare with checksum | ||
| // of existing sha256sum-<arch>.txt file for packages already available on the machine | ||
| // before performing air-gapped installation. | ||
| AirGappedChecksum string `json:"airGappedChecksum,omitempty"` |
There was a problem hiding this comment.
can we make this field optional?
There was a problem hiding this comment.
It was blocked on #313 for fuzzy testing, so I was only able to add generated manifests, make the field optional and backward value recovery after it got merged. This should be ready for review.
|
LGTM pending fixing CI checks and resolving @alexander-demicev's comment. |
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
air-gapped-version-check
branch
from
6f5fc3e to
3b188c9
Compare
alexander-demicev
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds
AirGappedChecksumfield to agent config. By using this field, a user might declare expected sha256sum checksum for the air gapped manifests and prevent incomplete or different package installation on the host.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #297
Depends on #313 for fuzzy test changes to make CI green
Special notes for your reviewer:
Internals of the
curl -sfL https://get.rke2.ioin the air-gapped mode already verify the contents of provided tar files based on the checksum fromsha256sum-<arch>.txt. Therefore theAirGappedChecksumdeclares the expected checksum for this file only to connect API definition with the prepared host pre-bootstrap state.Checklist: