Introduce v1beta1 api version #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
v1alpha2-api
branch
10 times, most recently
from
1e2eecf
to
1fb2bdb
Compare
Danil-Grigorev
changed the title
Danil-Grigorev
force-pushed
the
v1alpha2-api
branch
from
1fb2bdb
to
9b216bf
Compare
4 tasks
|
Lets update this to v1beta1 (instead of using #230) |
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
v1alpha2-api
branch
from
069c7a6
to
dc7c307
Compare
Danil-Grigorev
changed the title
|
@richardcase @salasberryfin The PR is updated and the tests are passing. This v1beta1 api has no changes from the current state of v1alpha1, but if we would change or remove some fields, needed conversions could be added later. |
|
Thanks @Danil-Grigorev. As discussed earlier today, after this is merged, we'll be adapting the changes in #226 so that new fields in the specification are already in `v1beta``. |
salasberryfin
previously approved these changes
Jan 8, 2024
richardcase
reviewed
Jan 9, 2024
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
v1alpha2-api
branch
from
f93d387
to
7a4225e
Compare
|
@richardcase All types are added and copyright is updated. |
salasberryfin
approved these changes
Jan 9, 2024
richardcase
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds v1beta1 api version and conversion webhooks. Does not include any actual changes to the API itself.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #231
Special notes for your reviewer:
Checklist: