-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce v1beta1 api version #187
Conversation
1e2eecf
to
1fb2bdb
Compare
1fb2bdb
to
9b216bf
Compare
Lets update this to v1beta1 (instead of using #230) |
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
069c7a6
to
dc7c307
Compare
@richardcase @salasberryfin The PR is updated and the tests are passing. This v1beta1 api has no changes from the current state of v1alpha1, but if we would change or remove some fields, needed conversions could be added later. |
Thanks @Danil-Grigorev. As discussed earlier today, after this is merged, we'll be adapting the changes in #226 so that new fields in the specification are already in `v1beta``. |
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
f93d387
to
7a4225e
Compare
@richardcase All types are added and copyright is updated. |
What this PR does / why we need it:
This change adds v1beta1 api version and conversion webhooks. Does not include any actual changes to the API itself.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #231
Special notes for your reviewer:
Checklist: