Add maxsurge option for control plane upgrade #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
maxsurge
branch
from
8ae9dc7 to
73d2d96
Compare
|
I will be working on tests in a follow-up PR, as we don't have any setup for unit testing of this controller |
richardcase
reviewed
Nov 2, 2023
alexander-demicev
force-pushed
the
maxsurge
branch
from
73d2d96 to
2e247cb
Compare
alexander-demicev
force-pushed
the
maxsurge
branch
2 times, most recently
from
3c96d7b to
69161e8
Compare
richardcase
reviewed
Nov 15, 2023
controlplane/internal/controllers/rke2controlplane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/internal/controllers/rke2controlplane_controller.go
Outdated
Show resolved
Hide resolved
alexander-demicev
force-pushed
the
maxsurge
branch
from
31e7eb1 to
c6f08cc
Compare
Closed
richardcase
reviewed
Nov 15, 2023
richardcase
previously approved these changes
Nov 15, 2023
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
maxsurge
branch
from
c6f08cc to
055e268
Compare
Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase
previously approved these changes
Nov 16, 2023
Danil-Grigorev
previously approved these changes
Nov 16, 2023
controlplane/internal/controllers/rke2controlplane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/internal/controllers/rke2controlplane_controller.go
Outdated
Show resolved
Hide resolved
furkatgofurov7
previously approved these changes
Nov 16, 2023
salasberryfin
previously approved these changes
Nov 16, 2023
Signed-off-by: Richard Case <richard.case@outlook.com>
richardcase
dismissed stale reviews from salasberryfin, furkatgofurov7, Danil-Grigorev, and themself
via
37320ae
richardcase
approved these changes
Nov 16, 2023
richardcase
requested review from
salasberryfin,
furkatgofurov7 and
Danil-Grigorev
furkatgofurov7
approved these changes
Nov 17, 2023
salasberryfin
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes: #166
Fixes: #193
Special notes for your reviewer:
Checklist: