Add arbitrary data field #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
arbitrary-cloud-init
branch
from
aa09d29 to
61d6e93
Compare
alexander-demicev
previously approved these changes
Nov 13, 2023
|
@Danil-Grigorev can you fix the CI? |
Need to add tests on top as well, will update soon. |
Danil-Grigorev
force-pushed
the
arbitrary-cloud-init
branch
3 times, most recently
from
3bc2210 to
4d53b56
Compare
alexander-demicev
previously approved these changes
Nov 14, 2023
richardcase
reviewed
Nov 15, 2023
| } | ||
|
|
||
| // Remove ignored fields from the map | ||
| for _, field := range ignoredCloudInitFields { |
There was a problem hiding this comment.
We should do this before we execute the template so that fields are removed before.
Danil-Grigorev
force-pushed
the
arbitrary-cloud-init
branch
from
4d53b56 to
48bb993
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
arbitrary-cloud-init
branch
from
48bb993 to
f62ad18
Compare
alexander-demicev
approved these changes
Nov 15, 2023
richardcase
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #167
Special notes for your reviewer:
Checklist: