Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indentation to generated RKE2 config #544

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add indentation to generated RKE2 config #544

merged 1 commit into from
Jan 10, 2025

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #524

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev marked this pull request as ready for review January 8, 2025 09:27
@alexander-demicev alexander-demicev requested a review from a team as a code owner January 8, 2025 09:27
@alexander-demicev alexander-demicev mentioned this pull request Jan 8, 2025
Closed
anmazzotti
anmazzotti previously approved these changes Jan 8, 2025
View reviewed changes
@alexander-demicev alexander-demicev requested a review from a team January 8, 2025 17:09
@Danil-Grigorev
Copy link
Contributor

Shouldn’t this PR also address changes to componentMapToSlice which seems important in the context of the issue?

From #524:

Anything else you would like to add:
AFAICS the problem is we use the componentMapToSlice function which is designed to format for environment variables.

@alexander-demicev
Copy link
Member Author

@Danil-Grigorev yes, you're right

@alexander-demicev alexander-demicev force-pushed the indentation branch 2 times, most recently from c4e9bd0 to 53a3b16 Compare January 10, 2025 09:54
@alexander-demicev
Add indentation to generated RKE2 config
7268382 
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@Danil-Grigorev Danil-Grigorev merged commit b9d98de into rancher:main Jan 10, 2025
5 checks passed
@alexander-demicev alexander-demicev deleted the indentation branch January 10, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmazzotti anmazzotti anmazzotti approved these changes

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RKE2 extraMounts still can't be used
3 participants
@alexander-demicev @Danil-Grigorev @anmazzotti