Merge pull request #12296 from rak-phillip/bugfix/12292-hook-cleanup

Replace `beforeDestroy` lifecycle option with `beforeUnmount`

shell/components/SortableTable/actions.js

@@ -18,7 +18,7 @@ export default {
     };
   },
 
-  beforeDestroy() {
+  beforeUnmount() {
     window.removeEventListener('resize', this.onWindowResize);
   },
 

shell/components/SortableTable/selection.js

@@ -20,7 +20,7 @@ export default {
     table.addEventListener('contextmenu', this._onRowContextBound);
   },
 
-  beforeDestroy() {
+  beforeUnmount() {
     const table = this.$el.querySelector('TABLE');
 
     table.removeEventListener('click', this._onRowClickBound);

shell/mixins/browser-tab-visibility.js

@@ -25,7 +25,7 @@ export default {
   mounted() {
     this.setTabVisibilityListener(true);
   },
-  beforeDestroy() {
+  beforeUnmount() {
     this.setTabVisibilityListener(false);
   },
 };

shell/mixins/metric-poller.js

@@ -13,7 +13,7 @@ export default {
     this.metricPoller.start();
   },
 
-  beforeDestroy() {
+  beforeUnmount() {
     this.metricPoller.stop();
   },
 };

shell/mixins/resource-fetch.js

@@ -48,7 +48,7 @@ export default {
     };
   },
 
-  beforeDestroy() {
+  beforeUnmount() {
     // make sure this only runs once, for the initialized instance
     if (this.init) {
       // clear up the store to make sure we aren't storing anything that might interfere with the next rendered list view