Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet landing page shows a vertical scroll bar #10632

Closed
nwmac opened this issue Mar 15, 2024 · 3 comments · Fixed by #12567
Closed

Fleet landing page shows a vertical scroll bar #10632

nwmac opened this issue Mar 15, 2024 · 3 comments · Fixed by #12567
Assignees
@IsaSih @momesgin
Labels
area/fleet kind/bug QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Milestone
v2.11.0

Comments

@nwmac
Copy link
Member

nwmac commented Mar 15, 2024

See below:

image

vertical scroll bar shown.

Looks like we need to remove the min-height: 100vh from the fleet-dashboard class.
@nwmac nwmac added the kind/bug label Mar 15, 2024
@nwmac nwmac added this to the v2.9.0 milestone Mar 15, 2024
@github-actions github-actions bot added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed [zube]: Backlog labels Mar 15, 2024
@nwmac nwmac modified the milestones: v2.9.0, v2.10.0 May 7, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive gaktive added QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1 and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 6, 2024
@momesgin momesgin self-assigned this Nov 6, 2024
@momesgin momesgin mentioned this issue Nov 8, 2024
Merged
7 tasks
@IsaSih IsaSih self-assigned this Nov 15, 2024
@IsaSih
Copy link

IsaSih commented Nov 15, 2024 •
edited
Loading

The scroll bar still exists in v2.11-4c985fcfe6a04e511ba5a3940d27a6a97dd4ba83-head and it's present in various screen resolutions. Moving back to Reopen

Screen.Recording.2024-11-14.at.18.56.47.mov

@momesgin
Copy link
Member

momesgin commented Nov 15, 2024 •
edited
Loading

The scroll bar still exists in v2.11-4c985fcfe6a04e511ba5a3940d27a6a97dd4ba83-head and it's present in various screen resolutions. Moving back to Reopen

Screen.Recording.2024-11-14.at.18.56.47.mov

@IsaSih could you please double-check if your env points to the latest dashboard?

@IsaSih
Copy link

IsaSih commented Dec 13, 2024

tests pass in v2.11-d224815d7cfbf4194db1ffdfb04676d55d1a2062-head

Image

@IsaSih IsaSih closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IsaSih IsaSih

@momesgin momesgin

Labels
area/fleet kind/bug QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Fix fleet dashboard page's scroll bar momesgin/dashboard
4 participants
@nwmac @gaktive @IsaSih @momesgin