Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fleet dashboard page's scroll bar #12567

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Nov 8, 2024

Summary

Fixes #10632

Occurred changes and/or fixed issues

Technical notes summary

Removed unnecessary class .fleet-dashboard as it wasn't referenced anywhere else, and its min-height: 100vh styling was causing the issue. Note that you would only see the scroll bar if you had the os setting enabled to always show the scroll bars:

Screenshot 2024-11-08 at 12 43 59 PM

Areas or cases that should be tested

Try different browsers and turn on the os setting mentioned above.

Areas which could experience regressions

I've already tried different pages on the fleet section and couldn't find any regression there, but would be good if a second person test it too.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Nov 8, 2024
@momesgin momesgin self-assigned this Nov 8, 2024
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momesgin momesgin merged commit b2c8400 into rancher:master Nov 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fleet landing page shows a vertical scroll bar
2 participants