Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App bar icon alignment broken #12758

Open
nwmac opened this issue Dec 3, 2024 · 0 comments · Fixed by #12827
Open

App bar icon alignment broken #12758

nwmac opened this issue Dec 3, 2024 · 0 comments · Fixed by #12827
Assignees
@a-arias @eva-vashkevich
Labels
kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/1 Size Estimate 1
Milestone
v2.11.0

Comments

@nwmac
Copy link
Member

nwmac commented Dec 3, 2024

If you have an extension that uses an image for an icon, the alignment is broken.

This appears to be due to this change: #12591

Before: (in 2.10)

image

Now: (in 2.11)

image

The css used to have the width set for the image, but now this was moved to only apply if the icon is provided via the icon font.
@nwmac nwmac added this to the v2.11.0 milestone Dec 3, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 3, 2024
@gaktive gaktive added the size/1 Size Estimate 1 label Dec 4, 2024
@eva-vashkevich eva-vashkevich mentioned this issue Dec 5, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-arias a-arias

@eva-vashkevich eva-vashkevich

Labels
kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/1 Size Estimate 1
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

[FIX] Fixed app icon aligntment for extensions with image icon eva-vashkevich/dashboard
4 participants
@nwmac @a-arias @gaktive @eva-vashkevich