Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed app icon aligntment for extensions with image icon #12827

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Dec 5, 2024

Summary

Fixes #12758

Changed css to exclude pins instead of specifying which element to apply to include more cases.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

  1. Install an extension from https://nwmac.github.io/rancher-dev-portal/
  2. All items on app bar (top level menu) should be positioned the same
  3. Create a new imported cluster without actually importing it.
  4. Pin the new cluster and local cluster. Pin positioning should be the same.

Areas which could experience regressions

Top level menu application bar

Screenshot/Video

Screenshot 2024-12-05 at 10 41 06 AM Screenshot 2024-12-05 at 10 40 57 AM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 92d7738 into rancher:master Dec 5, 2024
39 checks passed
@eva-vashkevich eva-vashkevich deleted the iss12758 branch December 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App bar icon alignment broken
2 participants