Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EKS - unable to add node groups to imported EKS cluster #12872

Open
mantis-toboggan-md opened this issue Jul 3, 2024 · 5 comments
Open
Assignees
Labels
area/eks kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@mantis-toboggan-md
Copy link
Member

Rancher Server Setup

  • Rancher version: v2.9-a57f7025abdd80a2912f7fe53247ef7e1d4993de-head
  • Installation option (Docker install/Helm Chart): helm
    • If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): k3s
  • Proxy/Cert Details: self-signed

Information about the Cluster

  • Kubernetes version:
  • Cluster Type (Local/Downstream): downstream imported EKS cluster with self-managed nodes

User Information

  • What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)
    admin

Describe the bug
After importing an EKS cluster with self-managed nodes, adding node groups through the UI doesn't work. The cluster stays in an 'updating' state for about half an hour before returning an error message
image (1)

To Reproduce
Create an EKS cluster with self-managed nodes https://docs.aws.amazon.com/eks/latest/userguide/launch-workers.html
Import the cluster into Rancher
Once the cluster has 'Active' status, edit and add a node group with default values

Result
The cluster stays in updating state for ~30 minutes before returning an error.

Expected Result
Users should be able to add node groups through the UI.

@Jono-SUSE-Rancher
Copy link

Kicked it out of v2.10 and giving you guys some time to triage for v2.10.1. cc: @kkaempf and @mbologna

@mjura mjura self-assigned this Nov 14, 2024
@kkaempf kkaempf modified the milestones: v2.10.1, v2.10.2 Dec 10, 2024
@mjura
Copy link
Contributor

mjura commented Dec 12, 2024

Kicked it out of v2.10 and giving you guys some time to triage for v2.10.1. cc: @kkaempf and @mbologna

As I see there is problem in UI, it is always trying to use Launch Template for every new node group. In case which you are describing Launch Template for your new Node Group is using NodeRole IAM which probably doesn't have access to EKS control plane.

@mjura
Copy link
Contributor

mjura commented Dec 12, 2024

To UI Team, please add possibility to create Node Groups without Launch Template. Launch Templates should be only optional.

Image

@kkaempf kkaempf transferred this issue from rancher/rancher Dec 12, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 12, 2024
@kkaempf kkaempf removed the team/highlander Highlander label Dec 12, 2024
@mantis-toboggan-md
Copy link
Member Author

To UI Team, please add possibility to create Node Groups without Launch Template. Launch Templates should be only optional.

@mjura the UI is already treating launch templates as optional, or at least attempting to. By default, no launch template is specified. Do we need to do something else? Here's the response to the POST request to create EKS cluster with a default node group:

Screenshot 2024-12-12 at 7 07 26 AM

@cpinjani
Copy link

@mantis-toboggan-md @mjura I am unable to reproduce the original reported issue.
Rancher: v2.10.1-alpha1, eks-operator: v1.10.1-rc.2

Steps

  • Create an EKS cluster with self-managed nodes
  • Import the cluster into Rancher:

image

  • Once the cluster has 'Active' status, edit and add a node group with default values ✅

image

Logs

time="2024-12-13T07:19:06Z" level=info msg="Starting eks.cattle.io/v1, Kind=EKSClusterConfig controller"
time="2024-12-13T07:19:06Z" level=info msg="Starting /v1, Kind=Secret controller"
time="2024-12-13T07:26:29Z" level=info msg="Waiting for cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] to update nodegroups [group1]"
time="2024-12-13T07:26:30Z" level=info msg="Waiting for cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] to update nodegroups [group1]"
time="2024-12-13T07:27:00Z" level=info msg="Waiting for cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] to update nodegroups [group1]"
time="2024-12-13T07:27:30Z" level=info msg="Waiting for cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] to update nodegroups [group1]"
time="2024-12-13T07:28:01Z" level=info msg="Waiting for cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] to update nodegroups [group1]"
time="2024-12-13T07:28:32Z" level=info msg="Cluster [auto-eks-cpinjani-hp-ci (id: c-dkwjf)] finished updating"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eks kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

6 participants