Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit imported EKS cluster having self-managed nodes #10335

Closed
cpinjani opened this issue Jan 26, 2024 · 5 comments · Fixed by #11294
Closed

Unable to edit imported EKS cluster having self-managed nodes #10335

cpinjani opened this issue Jan 26, 2024 · 5 comments · Fixed by #11294
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing team/highlander Highlander
Milestone

Comments

@cpinjani
Copy link

Setup
Rancher version: v2.8-d0a177f1745fe14a0b3de7483aa3ef895d1ab967-head
Rancher UI Extensions: None
Browser type & version: Chrome latest

Describe the bug
Unable to edit imported EKS cluster having self-managed nodes. Saving the changes after editing the cluster is not working.

To Reproduce

  • Import EKS cluster having self-managed nodes
  • Edit the cluster and upgrade k8s version or add cluster tags or enable logging, etc.

Expected Result
In rancher/eks-operator#301, support is added for self-managed EKS nodes.
User must be able to edit and perform operations on imported EKS cluster having self-managed nodes

Screenshots
image

cc: @mjura @salasberryfin

@richard-cox
Copy link
Member

Our go-forward milestone is 2.9.0 and we backport as required. Is this needed in 2.8?

@cpinjani
Copy link
Author

The base issue has milestone v2.8-Next1.
@kkaempf Can you please confirm the target milestone for this ?

@kkaempf
Copy link

kkaempf commented Jan 29, 2024

The backend (aka eks-operator) fix will be shipped with 2.8-Next1.

I don't know the priority backlog of UI and if the issue at hand needs to be accelerated. Maybe @davidstauffer knows ?

@mantis-toboggan-md
Copy link
Member

mantis-toboggan-md commented Jul 3, 2024

I've been working on fixing the UI side, correcting any invalid ui errors and making sure cluster information correctly populates the form (pr here #11294); however, I found that I was not able to add node groups to imported EKS clusters with only self managed nodes. FYIU @cpinjani I filed a related issue #12872

@cpinjani
Copy link
Author

Validation passed on the reported issue, able to perform cluster level edits on cluster.
Rancher - v2.9-637346f76ea2bb71a82ea6e00a2779f61610a2a4-head
Dashboard - master 3da1205

imported.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing team/highlander Highlander
6 participants