EKS: edit imported clusters, and clusters with exclusively self-managed nodes #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix networking subnet mode display
…en configured to create a vpc and subnet automatically
mantis-toboggan-md
force-pushed
the
eks-fix-import
branch
from
f32fb7c to
d3ae4a9
Compare
torchiaf
reviewed
Jun 27, 2024
pkg/eks/components/CruEKS.vue
Outdated
| @@ -409,6 +418,9 @@ export default defineComponent({ | |||
| }, | |||
|
|
|||
| async actuallySave(): Promise<void> { | |||
| if (!this.isNewOrUnprovisioned && !this.nodeGroups.length) { | |||
| delete this.normanCluster.eksConfig.nodeGroups; | |||
There was a problem hiding this comment.
this.normanCluster.eksConfig is possibly undefined. We can include it in the if condition before delete.
torchiaf
requested changes
Jun 27, 2024
|
Updated to include #11291 - the same syncUpstreamConfig functionality needs to be added to GKE provisioning. No extra logic around node groups needed for GKE though. |
|
I hit an additional issue with this: due to pre-existing norman api validation it's not possible to add node groups then delete all node groups through the UI. I've separated that out into a different issue, as it needs backend work as well and the other fixes in this PR are required to reproduce the bug. |
This was referenced Jul 2, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
…ed nodes (rancher#11294) * sync upstream eks spec on edit * allow for nil nodeGroups fix networking subnet mode display * split up syncUpstreamConfig test * update subnets display for imported clusters and clusters that had been configured to create a vpc and subnet automatically * fix ts in eks save function * add syncUpstreamConfig to gke provisioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11100
Fixes #11104
Fixes #10335
Fixes #11291
Occurred changes and/or fixed issues
This PR updates EKS provisioning to incorporate the same upstream syncing behavior as AKS - see #11120 for some background on why this is needed. This PR adds some fixes to the syncing utility as well as unit tests around the problems I found while working on the PR. There are also some minor fixes around the EKS components to correct console errors shown when editing an imported cluster.
Special notes about EKS:
Areas or cases that should be tested
user should be able to add and remove node groupsEDIT: removing all node groups is causing issues due to backend validation, issue filed here EKS - unable to remove all managed nodegroups from imported EKS cluster that also has self-managed nodes #11336
Checklist