Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] Support custom instance roles for node groups #4568

Closed
thedadams opened this issue Nov 15, 2021 · 21 comments
Closed

[EKS] Support custom instance roles for node groups #4568

thedadams opened this issue Nov 15, 2021 · 21 comments

Comments

@thedadams
Copy link

thedadams commented Nov 15, 2021

In order to support custom node instance roles for EKS clusters, a new dropdown should be added to the "Add nodegroup" section of the UI.

This dropdown should:

  1. Get the available node instance roles from the AWS API to populate the dropdown.
  2. Filter out the node instance roles that are prefixed with rancher-managed-
  3. The field name should be nodeInstanceRole
  4. The value passed to the Rancher API should be a string. If no role is selected for a nodegroup, then the empty string should be passed.

SURE-4536

@snasovich
Copy link
Contributor

@nwmac @gaktive , is this something that can be implemented in 2.6.3? We're working on getting backend done so it's technically backend blocked, but hopefully some work can be started with the assumption this new field is added as per PR linked to backend issue.

@snasovich snasovich modified the milestones: v2.6.3, v2.6.4 Nov 16, 2021
@gaktive
Copy link
Member

gaktive commented Jan 19, 2022

@snasovich do you have the backend ticket somewhere to refer to? Otherwise, what is the state of the backend if we can target this for 2.6.4?

@thedadams
Copy link
Author

Backend issue: rancher/rancher#29071

@snasovich snasovich modified the milestones: v2.6.4, v2.6.5 Jan 27, 2022
@snasovich
Copy link
Contributor

@gaktive , so far we're tentatively targeting this for 2.6.5. I've updated your milestone to match.

@gaktive
Copy link
Member

gaktive commented Apr 6, 2022

@snasovich i see that the backend ticket no longer has a milestone now. If that's expected, I can place this ticket in 2.6.x.

@snasovich
Copy link
Contributor

snasovich commented Sep 16, 2022

@gaktive @nwmac , we're working on getting backend changes for this done for 2.7.0 (not 100% sure we'll make it by deadline though). Is it possible to have UI changes ready for 2.7.0 release?
cc: @Sahota1225

@gaktive gaktive added the team/area2 Hostbusters label Sep 16, 2022
@gaktive
Copy link
Member

gaktive commented Sep 16, 2022

@snasovich is the ask to have UI ready before backend? I'll check if we can start work and then wait, though do let us know if any design changes are anticipated.

@snasovich
Copy link
Contributor

@gaktive , the plan is to get backend changes merged by end of day 9/20/22. I'm not sure how this aligns with your deadlines, so if starting before backend is ready helps, that would be good.
@annablender , let us know if whatever is outlined in the description of this issue needs to be updated based on your work on backend.

@gaktive gaktive modified the milestones: v2.7.0, v2.7.1 Sep 19, 2022
@gaktive gaktive modified the milestones: v2.7.2, v2.7.1 Oct 5, 2022
@Josh-Diamond
Copy link

Looks like drone failed, not quite ready to-test

Restarting drone build now, moving to review until drone passes.

@Josh-Diamond
Copy link

Unable to restart drone - [perhaps lack of permissions?]

Requested assistance from UI team (internally)

@a-blender
Copy link

@Josh-Diamond Check if you've logged in to drone

@Josh-Diamond
Copy link

Ticket #4568 - Test Results - ✅

With Docker on a single-node instance:

Verified on rancher v2.7-0504ce63c1cad67b2c2be14a0325533b60902832-head:

  1. Fresh install of rancher v2.7-head
  2. Provision a downstream EKS cluster w/ custom instance role assigned for node group
  3. Once active, navigate to Cluster Management > Edit Config > Node Instance Role
  4. Verified - accurate custom role is seen and present; as expected

Screenshot:
Screenshot 2023-02-08 at 2 27 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants