-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.6.x] - ensure all EKS versions are in 2.6.x branches #7931
Comments
We should figure out if anything else happened during branching for the 2.6.9 release since there may be other missing PRs in the release from |
After comparing commits in master and the release-2.6.9 branch in the Ember repo, I believe the only other change that needs to be backported is #6774. |
Based on discussion with @snasovich, we may have to revert rancher/ui#4899 since this ties into a complex web of supporting older k8s versions that 2.6.x has to but 2.7.x doesn't. @nwmac should we Reopen this before QA starts testing? |
Reopening for QA validations |
@gaktive Can you confirm if this is ready for QA validations? Also is there a forwardport ticket to this for 2.7.2? |
@richa was rancher/ui#4899 reverted? I can't tell from the history in that PR or here what happened. @sowmyav27 for 2.7.x, this ticket isn't relevant since that work was already done:
This ticket was created because it was discovered that prior backports never made it into 2.6.9 due to some branching confusion. |
Another internal reference: SURE-5880 |
This should be ready for QA as far as I understand. |
@snasovich as I look for your past comments, what did 2.6.x and 2.7.x have to support with EKS k8s versions? You said somewhere that we had to support older versions in 2.6.x for a while and we've gone to 1.20-1.24 in this work to fix things. |
@gaktive , as for your last comment, replied offline (in Slack). |
We had a fix for updating the EKS versions to include k8s 1.23 & 1.24 for 2.6.x but they only made it into master, not the 2.6 branches so we still only show <1.22 for 2.6.9 and 2.6-latest.
1.23: rancher/ui#4890
1.24: rancher/ui#4908
Remove older versions: rancher/ui#4899
The text was updated successfully, but these errors were encountered: