add 1.24 to hardcoded EKS versions #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I think it should not be merged to master because it's in the 2.7.1 milestone. |
catherineluse
approved these changes
Oct 26, 2022
mjura
reviewed
Nov 8, 2022
| @@ -683,7 +683,7 @@ export const EKS_REGIONS = [ | |||
| ]; | |||
|
|
|||
| // from https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html | |||
| export const EKS_VERSIONS = ['1.23']; // sort newest->oldest so we dont have to run any logic to sort like other provider versions | |||
| export const EKS_VERSIONS = ['1.24', '1.23']; // sort newest->oldest so we dont have to run any logic to sort like other provider versions | |||
There was a problem hiding this comment.
Until they, Amazon didn't released EKS in version 1.24, probably this change needs to wait. Please check https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
There was a problem hiding this comment.
It can be merged now, EKS v1.24 was released https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7219
edit: because we keep having to do this, tech debt issue to look for a better way is here: rancher/dashboard#7295