-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use API to get EKS region and instance data instead of hardcoding #7295
Comments
Someone found a way to do it indirectly https://stackoverflow.com/a/71448603/5370501 |
There is already an issue about replacing the hardcoded EKS versions #4401, so I'm editing the scope of the issue to region and instance data. Related backend issue for EKS versions is here rancher/rancher#33766 |
Also for reference, there is a SUSE project https://github.com/SUSE-Enceladus/aws-regions - this uses the AWS CLI project on GitHub - https://github.com/boto/botocore - looks like it maintains up to date data that could be used: https://github.com/boto/botocore/blob/develop/botocore/data/endpoints.json |
For 2.7.next2, we should maybe spend |
Need to also consider EC2 regions and regions list used when supplying credentials This covers old and new UIs. Old UI New UI |
@mantis-toboggan-md when we port EKS, is this doable in Vue? or is that even possible? We could potentially close this if this is also covered with existing migration plans. |
@gaktive I think it would make sense to tackle this at the same time as the EKS migration, but I don't think this enhancement is implicit in that plan - it's worth calling out directly. It wouldn't be any harder in Vue than Ember. |
Tests pass on v2.9-16190ecee0aa3fb4aa570aa0fc932a36d9dcd082-head |
hi, is this feature merged? |
The UI has a fair bit of hardcoded amazon data, see: https://github.com/rancher/ui/blob/master/lib/shared/addon/utils/amazon.js
In particular we are manually keeping track of which EKS versions to show. We should investigate whether or not there is an API we can use for EKS versions and possibly region/instance data as well.
The text was updated successfully, but these errors were encountered: