Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API to get EKS region and instance data instead of hardcoding #7295

Closed
mantis-toboggan-md opened this issue Oct 26, 2022 · 9 comments
Closed
Assignees
Labels
ember Ember UI Issue kind/enhancement kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@mantis-toboggan-md
Copy link
Member

The UI has a fair bit of hardcoded amazon data, see: https://github.com/rancher/ui/blob/master/lib/shared/addon/utils/amazon.js
In particular we are manually keeping track of which EKS versions to show. We should investigate whether or not there is an API we can use for EKS versions and possibly region/instance data as well.

@catherineluse
Copy link
Contributor

Someone found a way to do it indirectly https://stackoverflow.com/a/71448603/5370501

@catherineluse
Copy link
Contributor

catherineluse commented Nov 4, 2022

There is already an issue about replacing the hardcoded EKS versions #4401, so I'm editing the scope of the issue to region and instance data.

Related backend issue for EKS versions is here rancher/rancher#33766

@catherineluse catherineluse changed the title Hardcode less EKS metadata Use API to get EKS region and instance data instead of hardcoding Nov 4, 2022
@gaktive gaktive added this to the v2.7.next2 milestone Dec 1, 2022
@nwmac nwmac added ember Ember UI Issue [zube]: Backlog and removed [zube]: To Triage labels Jan 12, 2023
@nwmac
Copy link
Member

nwmac commented Jan 17, 2023

Also for reference, there is a SUSE project https://github.com/SUSE-Enceladus/aws-regions - this uses the AWS CLI project on GitHub - https://github.com/boto/botocore - looks like it maintains up to date data that could be used: https://github.com/boto/botocore/blob/develop/botocore/data/endpoints.json

@gaktive
Copy link
Member

gaktive commented Feb 1, 2023

For 2.7.next2, we should maybe spend size/5 on this so we need to estimate the effort here; if it's larger, then we push it out. But this would help with a regular series of requests we get.

@richard-cox
Copy link
Member

Need to also consider EC2 regions and regions list used when supplying credentials

This covers old and new UIs.

Old UI
REGIONS - Used for EC2 AND credentials (used by both ec2 and eks)
EKS_REGIONS - Used for eks things

New UI
TBD

@gaktive
Copy link
Member

gaktive commented Aug 3, 2023

@mantis-toboggan-md when we port EKS, is this doable in Vue? or is that even possible? We could potentially close this if this is also covered with existing migration plans.

@gaktive gaktive modified the milestones: v2.8.0, v2.8.next1 Aug 3, 2023
@mantis-toboggan-md
Copy link
Member Author

mantis-toboggan-md commented Aug 3, 2023

@gaktive I think it would make sense to tackle this at the same time as the EKS migration, but I don't think this enhancement is implicit in that plan - it's worth calling out directly. It wouldn't be any harder in Vue than Ember.

@nwmac nwmac modified the milestones: v2.8.next1, v2.8.next2 Oct 23, 2023
@nwmac nwmac modified the milestones: v2.8.next2, v2.9.0 Feb 27, 2024
@IsaSih
Copy link

IsaSih commented Jun 18, 2024

Tests pass on v2.9-16190ecee0aa3fb4aa570aa0fc932a36d9dcd082-head

@IsaSih IsaSih closed this as completed Jun 18, 2024
@crossRT
Copy link

crossRT commented Dec 13, 2024

hi, is this feature merged?
Because the new AWS region ap-southeast-5 has been launched, I noticed another issue (#12833): the AWS region is still being updated manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ember Ember UI Issue kind/enhancement kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

No branches or pull requests

7 participants