Enable new EKS regions & versions

[gaktive]

From @furkatgofurov7, we need to update the hardcoded EKS supported k8s versions list with newer versions based on https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

Since tech debt #7295 is still open, we need to manually update this. PRs provided already.

rancher/ui#5009
rancher/ui#5008

[gaktive]

Similar (and already approved): rancher/ui#5006

@pgonin & @kkaempf let us know if there are more.

[pgonin]

@gaktive @furkatgofurov7 while we're on the topic we could add the missing following regions:
ap-southeast-4
ap-south-2
me-central-1
eu-central-2
eu-south-2

Though I have not checked if EKS is available in all those regions

[furkatgofurov7]

@pgonin I'll check the list for EKS and send a PR if I find any of the regions are missing

[gaktive]

We'd need to do #8721 first since adding unsupported versions requires a fix.

[cpinjani]

Validated the fixes from below PRs on build > v2.7.5-rc5
rancher/ui#5009
rancher/ui#5008

Able to provision EKS cluster with version 1.25, 1.26 and in region ap-northeast-3:

[furkatgofurov7]

@gaktive @furkatgofurov7 while we're on the topic we could add the missing following regions: ap-southeast-4 ap-south-2 me-central-1 eu-central-2 eu-south-2

Though I have not checked if EKS is available in all those regions

@pgonin here is the pr: rancher/ui#5037

[cpinjani]

Test Result - ❌
Validated changes from rancher/ui#5037 on build

v2.7-head - 9a33c24

There is mismatch between, supported AWS region list for Cloud credentials <-> AWS region list for provisioning EKS clusters. Therefore provisioning EKS cluster in newly added regions fails eg. eu-south-2 (since eu-south-2 is not present in AWS cloud credentials regions list)

To reproduce

• Add AWS cloud credentials in supported region
• Provision EKS cluster in new region eg. eu-south2

[richard-cox]

Blocked on rancher/machine#209 (though we could get the PR ready to go).

From lib/shared/addon/utils/amazon.js REGIONS should match collection updated in rancher/machine#209. In theory, as the other collection EKS_REGIONS has updated, that's all that needs to happen

[rmweir]

@richard-cox that I was late to review that PR and it is stale now. Once its updated anyone can review including you, see rancher/machine#209 (comment). Also, KEv2 doesn't use rancher-machine. You shouldn't need that PR for it.

[richard-cox]

I think there's a knowledge gap UI side how this part works.

We have two helper collections which contain amazon regions

• REGIONS
  • https://github.com/rancher/ui/blob/master/lib/shared/addon/utils/amazon.js#L627
  • Used when validating credentials and in the node driver world
  • Collection is commented with below, which i think links us to the rancher/machine change

    • // These need to match the supported list in docker-machine:
      // https://github.com/docker/machine/blob/master/drivers/amazonec2/region.go
      

• EKS_REGIONS
  • Used in the cluster driver world
  • https://github.com/rancher/ui/blob/master/lib/shared/addon/utils/amazon.js#LL657C14-L657C25

The questions are...

• Should the regions list that supports node drivers track the collection in Add new regions and corresponding AMIs machine#209?
  • If so we should get that PR in to support the new changes UI side
  • UI side we can't really test / approve that PR
• Can the same regions list be used for both cluster and node driver worlds?
  • If so UI side we just keep both our lists aligned

[rmweir]

We use rancher-machine to generate the cloud credentials I believe but otherwise EKS should not use or depend on rancher-driver at all. EKS also does not use any driver itself. It uses the eks-operator.

[richard-cox]

Ok, so anything AWS credentials related needs to have the same regions list as https://github.com/rancher/machine/blob/master/drivers/amazonec2/region.go#L13?

In the node driver world, used to create ec2 nodes, does the region list have an restrictions other than it needs to appear in https://cloud-images.ubuntu.com/locator/ec2/?

Assuming there are no restrictions other than ami list on ec2 nodes

• Add new regions and corresponding AMIs machine#209 needs to merge (as the UI will use those regions to test AWS creds)
• rancher/ui lib/shared/addon/utils/amazon.js REGIONS needs updating with new regions (aligned with above PR and EKS_REGIONS updated via Add missing regions to the EKS_REGIONS list ui#5037)

[rmweir]

Not necessarily. That is used for provisoning non EKS clusters. EKS regions are usually a smaller subset and no ami info is needed because EKS does that automatically. The AMI info is specifically for when we create ec2 instances which we do not do ourselves for EKS.

As for EC2, I don't think so?

I don't think that's needed for creds. Creds uses rancher-machine to understand what the shape of the credential will be, AMI/region info is irrelevant here. I don't think it does much else with it rancher-machine for creds.

[richard-cox]

/forwardport v2.7.next3

[rancherbot]

@richard-cox, Target is empty in comment for issue 8701 in repository dashboard, skipping comment

[gaktive]

@richard-cox looks like 2.7.5 is merged so this ticket is now for the forward port?

[richard-cox]

@gaktive this one is for 2.7.5, #9181 is for 2.7q3 / master

[richard-cox]

until rancher/rancher#41914 merges, in order to test this, in Settings --> Settings

• ui-index to https://releases.rancher.com/ui/release-2.7.5/index.html,
• ui-dashboard-index to https://releases.rancher.com/dashboard/release-2.7.5/index.html,
• ui-offline-preferred to Remote

... and refresh

[gaktive]

PR 41914 has been merged.

[cpinjani]

Validated the fixes from below merged PRs on build > v2.7-3aedc24d3087c3bbc4deb4d8c5ae40f55945e913-head
rancher/ui#5009
rancher/ui#5008
rancher/ui#5037
rancher/ui#5039

New regions added: ap-northeast-3, ap-southeast-4, ap-south-2, me-central-1, eu-central-2, eu-south-2
New versions added: 1.25, 1.26

Results

1. The new EKS regions and versions are visible and selectable on create EKS cluster page, while adding new cloud credentials and EKS regions list
2. Able to create EKS cluster in all new regions and new versions