-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new regions and corresponding AMIs #209
Add new regions and corresponding AMIs #209
Conversation
@rmweir can you PTAL, thanks! |
@furkatgofurov7 my bad but these look out of date now. Please update. Anyone can approve these PRs as long as they check the AMIs against the list, this includes UI. |
95d6386
to
cb05333
Compare
@rmweir updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like a test is failing so LGTM once that is fixed. |
All tests are failing with the same message:
and looks like not relevant to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI fails because the function TestValidateAwsRegionInvalid expects the region "eu-central-2" is not in the regionDetails
list.
To make the CI happy, you must change the above function to use another value for testing.
cb05333
to
44717c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as the CI passed.
We have added new regions in rancher/ui#5037 to the rancher UI and the new regions are visible. However when validating them, it was noticed that there is mismatch between, supported AWS region list for Cloud credentials <-> AWS region list for provisioning EKS clusters. More info here: rancher/dashboard#8701 (comment)
This PR adds those new regions to the regions list with it's corresponding AMIs from https://cloud-images.ubuntu.com/locator/ec2/