Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new EKS regions can be selected when validating creds #5039

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

richard-cox
Copy link
Member

Proposed changes

  • This means when users create creds they can be validated against one of the new regions
  • This also means users can select these creds when creating EC2 based RKE1 clusters

Linked Issues

rancher/dashboard#8701

Further comments

I haven't managed to successfully test EKS OR RKE1 EC2 in these regions, they're blocked to me

- This means users can validate their creds against one of these when creating creds in the EKS context
- This also means users can select these creds when creating EC2 based RKE1 clusters
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the change looks straightforward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants