-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new available EKS k8s versions to hardcoded list #5009
Add new available EKS k8s versions to hardcoded list #5009
Conversation
Signed-off by: Furkat Gofurov (furkat.gofurov@suse.com)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we have to test it first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just about to approve this after bringing up a 1.25 cluster, but noticed a bug in the way we handle the initial value - rancher/dashboard#8721.
Will look for someone our side to fix, but happy for anyone in this PR to check it out (just let us know.
Until that's fixed we can't merge this issue. I'll mark it with Request changes
just so it's clear we shouldn't merge yet.
@mjura once this is all sorted, did you want to do independent validation before this merges?
Edit - Alternatively, if ui-k8s-default-version-range
is unlikely to change until we release again, 1.26 could be removed as an option
Edit 2 - FWIW both 1.25 and 1.26 provisioned ok and i could browse resources in the Explorer. Didn't do any thorough tests though
DO NOT MERGE, until #5009 (review) is resolved! /hold Thanks @richard-cox for bringing this up, let's make it clear so that it will not be merged accidentally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing stale review
Signed-off by: Furkat Gofurov (furkat.gofurov@suse.com)
Updates hardcoded EKS supported k8s versions list with newer versions based on https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html
Since tech debt rancher/dashboard#7295 is still open, we need to manually update this.
@mjura @pgonin