Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Delivery - User with custom role with access to only list GitRepos can see the Add repo UI elements #8467

Closed
izaac opened this issue Mar 19, 2023 · 4 comments · Fixed by #8500 or #8590

Comments

@izaac
Copy link
Contributor

izaac commented Mar 19, 2023

Setup

  • Rancher version: v2.7-head a49d36c
  • Fleet version: v0.6.0-rc.5
  • Browser type & version: Firefox Chrome

Describe the bug

A user with permissions to only list GitRepos is shown the Add Repository UI elements.

To Reproduce

  • Add a new user role with all permissions (create, delete, list, etc) on fleetworkspaces resources.
  • Add access to gitrepos resources but only to list

Result

The user see the add repositories UI elements.

Both cases:

  • GitRepos exist
  • GitRepos do not exist

The user can't add the GitRepo as expected. With error: <user> is not able to add the repository as expected. ("Method POST not supported")

Expected Result
Access to the existing GitRepos list, but no add repository elements.

@nwmac
Copy link
Member

nwmac commented Mar 21, 2023

@Shavindra This is assigned to Nancy, but this is work you did originally - perhaps you can work with Nancy

@mantis-toboggan-md
Copy link
Member

/backport v2.7.2

@bmdepesa
Copy link
Member

Reopening for testing

@izaac
Copy link
Contributor Author

izaac commented Apr 4, 2023

@mantis-toboggan-md Closing as validated.

I've opened a separate issue for the workspaces elements I am still seeing if a user doesn't have permissions on fleetworkspaces
#8624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment