hide continuous delivery get started btn if user cant create gitrepos #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - confirmed this change by following repro steps as defined in issue. |
rak-phillip
approved these changes
Apr 3, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8467 see comment on backport here
Occurred changes and/or fixed issues
Updated the fleet landing page shown when a user has no git repos to hide the 'get started' button when the user can't create git repos.
Technical notes summary
I've updated the
permissionsproperty to check available methods on the git repo schema rather than just checking for its existence - though git repos were added to this permission check previously, I don't see them used in the component elsewhere, so this change looks fine to me.Areas or cases that should be tested