Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Allow extensions to load before login #9814

Closed
rohitsakala opened this issue Sep 29, 2023 · 21 comments · Fixed by #10727
Closed

Extensions: Allow extensions to load before login #9814

rohitsakala opened this issue Sep 29, 2023 · 21 comments · Fixed by #10727
Assignees
Labels
area/extensions area/harvester JIRA kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing release-note size/5 Size Estimate 5 status/release-note-added
Milestone

Comments

@rohitsakala
Copy link
Member

rohitsakala commented Sep 29, 2023

Is your feature request related to a problem? Please describe.
We need some UI extensions to load before login such internationalization, custom login page, etc..

Describe the solution you'd like
The current solution being explored by the Mapps team is giving the system:unauthenticated access to UI-plugins CRD but the spike is still going on.

Describe alternatives you've considered
N/A

Additional context
Right now, there is no requirement from UI for this issue. But, after the completion of the spike, the Mapps team will edit this issue if there are any UI requirements.
JIRA Issue - https://jira.suse.com/browse/SURE-6315

@richard-cox
Copy link
Member

The UI will need to load the plugins earlier than it currently does. Hopefully it should be as clean as simply moving the initialisation stuff, but needs some careful thought

@richard-cox
Copy link
Member

@rohitsakala is there a target MS for this one too?

@rohitsakala
Copy link
Member Author

@richard-cox Yes, that would be Q1-2.8 Rancher release. I don't have permissions to add milestone

@richard-cox richard-cox added this to the v2.8.next1 milestone Oct 2, 2023
@gaktive
Copy link
Member

gaktive commented Oct 12, 2023

Internal reference: SURE-6315

@nwmac nwmac added the JIRA label Feb 20, 2024
@nwmac nwmac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Mar 7, 2024
@gaktive
Copy link
Member

gaktive commented Mar 14, 2024

As @rak-phillip spotted, the UI plugin behaviour changed in rancher/rancher#44230 so that the ui-plugin-operator is now inside Rancher. This means that either we can work on this or we have to check if we have to change the dashboard behaviour.

@rohitsakala
Copy link
Member Author

@diogoasouza Can you update this issue with the expectations that we need from the UI team and also update the JIRA issue corresponding to this and relations with the backend issue ?

@diogoasouza
Copy link

diogoasouza commented Mar 15, 2024

@rohitsakala Sure!
The behavior shouldn't have changed, just the endpoints. The ui-plugin-operator helm chart should not be installed anymore.
There are a couple of new ones:

  1. /v1/uiplugins: This is the equivalent to the index.json endpoint from before, with the main difference being that it works with unauthenticated users as well if the noAuth flag of the CRD is set to true.
  2. /v1/uiplugins/{name}/{version}/{rest:.*}: This is the endpoint to get the files from the extension. Should have the same behavior as the one from the operator, with the difference being handling unauthenticated users

@gaktive
Copy link
Member

gaktive commented Mar 20, 2024

In the extension examples repo, there's something to try out using the UK locale.

@gaktive
Copy link
Member

gaktive commented Mar 20, 2024

We should check the behaviour upon logout and relogin since we may have something running and not loaded.

@gaktive gaktive added size/5 Size Estimate 5 [zube]: Groomed and removed [zube]: Backlog labels Mar 20, 2024
codyrancher added a commit to codyrancher/dashboard that referenced this issue Mar 29, 2024
codyrancher added a commit to codyrancher/dashboard that referenced this issue Apr 10, 2024
codyrancher added a commit to codyrancher/dashboard that referenced this issue Apr 10, 2024
@yonasberhe23
Copy link
Contributor

yonasberhe23 commented Apr 30, 2024

manual testing is needed to cover the recommended test scenario mentioned in the pr

A cluster with 2 versions of harvester and navigating between the two separate instances

the other scenarios seem to be covered by the e2e tests.

cc @izaac

@yonasberhe23 yonasberhe23 added the QA/manual-test Indicates issue requires manually testing label Jul 5, 2024
@izaac izaac self-assigned this Jul 19, 2024
@izaac
Copy link
Contributor

izaac commented Jul 19, 2024

This issue needs a final validation on a harvester cluster scenario. I've added the label to reflect that.

@izaac izaac removed their assignment Jul 19, 2024
@lanfon72
Copy link
Member

lanfon72 commented Jul 23, 2024

Hi @yonasberhe23 and @izaac, I checked changes in PR #10727, as the extensions function is outside of Harvester, I think it will not affect Harvester's behaviors?

Or and I misunderstanding something?

@richard-cox
Copy link
Member

@lanfon72 The important part is https://github.com/rancher/dashboard/pull/10727/files#diff-1898a7b94117e7be24d1cb0e9c46083b62be96b947436ad725d71efa650ed01d which may cause a regression in the way the ui loads the harvester extension from an old harvester and then a newer one from a newer harvester. The user should be able to switch back and forth, specifically being able to exercise newer functionality in the newer harvester.

@IsaSih
Copy link

IsaSih commented Jul 26, 2024

tested v2.9.0-rc3. Switching back and forth from harvester clusters with different versions 1.3.1 and 1.2.2. Extensions loaded as expected.

Image
Image

@IsaSih IsaSih closed this as completed Jul 26, 2024
@noahgildersleeve
Copy link
Contributor

noahgildersleeve commented Jul 26, 2024

I was checking a bit more into this after reading the earlier comments more closely.

  • It doesn’t show SR-IOV GPU in advanced settings on v1.3.1
  • it doesn’t show vGPU in advanced settings on v1.3.1
  • It’s not loading serial console on either v1.2.2 or v1.3.1 for accessing the VMs
  • It’s not loading web VNC on v1.2.2 or v1.3.1 for accessing the VMs

Here are some screenshots. The one missing the settings section are from Rancher, the 0one that has it is the Harvester UI.
Greenshot 2024-07-25 18 34 43
Greenshot 2024-07-25 18 33 36
Greenshot 2024-07-25 18 32 55
Greenshot 2024-07-25 18 30 48

@codyrancher
Copy link
Contributor

@noahgildersleeve was this caused when switching between different versions of harvester clusters or were these failing to load even when on refresh?

If it's a problem even on refresh I don't think it's related to this issue.

@gaktive
Copy link
Member

gaktive commented Jul 26, 2024

Will hold until moving into the Reopened column until this is clarified. As a result, I can't tell if this is a blocker yet. @noahgildersleeve keep us posted.

@gaktive
Copy link
Member

gaktive commented Jul 26, 2024

@noahgildersleeve this reads like a separate problem from the original ticket's intent.

@richard-cox
Copy link
Member

Release notes..

VM Management (Harvester)

Known Issues

In the Rancher UI when navigating between Harvester clusters of different versions a refresh may be required to view version specific functionality.

@richard-cox
Copy link
Member

@richard-cox
Copy link
Member

Give comment above, this feature is now complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions area/harvester JIRA kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing release-note size/5 Size Estimate 5 status/release-note-added
Projects
None yet
Development

Successfully merging a pull request may close this issue.