-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions: Allow extensions to load before login #9814
Comments
The UI will need to load the plugins earlier than it currently does. Hopefully it should be as clean as simply moving the initialisation stuff, but needs some careful thought |
@rohitsakala is there a target MS for this one too? |
@richard-cox Yes, that would be Q1-2.8 Rancher release. I don't have permissions to add milestone |
Internal reference: SURE-6315 |
As @rak-phillip spotted, the UI plugin behaviour changed in rancher/rancher#44230 so that the ui-plugin-operator is now inside Rancher. This means that either we can work on this or we have to check if we have to change the dashboard behaviour. |
@diogoasouza Can you update this issue with the expectations that we need from the UI team and also update the JIRA issue corresponding to this and relations with the backend issue ? |
@rohitsakala Sure!
|
In the extension examples repo, there's something to try out using the UK locale. |
We should check the behaviour upon logout and relogin since we may have something running and not loaded. |
manual testing is needed to cover the recommended test scenario mentioned in the pr
the other scenarios seem to be covered by the e2e tests. cc @izaac |
This issue needs a final validation on a harvester cluster scenario. I've added the label to reflect that. |
Hi @yonasberhe23 and @izaac, I checked changes in PR #10727, as the extensions function is outside of Harvester, I think it will not affect Harvester's behaviors? Or and I misunderstanding something? |
@lanfon72 The important part is https://github.com/rancher/dashboard/pull/10727/files#diff-1898a7b94117e7be24d1cb0e9c46083b62be96b947436ad725d71efa650ed01d which may cause a regression in the way the ui loads the harvester extension from an old harvester and then a newer one from a newer harvester. The user should be able to switch back and forth, specifically being able to exercise newer functionality in the newer harvester. |
@noahgildersleeve was this caused when switching between different versions of harvester clusters or were these failing to load even when on refresh? If it's a problem even on refresh I don't think it's related to this issue. |
Will hold until moving into the Reopened column until this is clarified. As a result, I can't tell if this is a blocker yet. @noahgildersleeve keep us posted. |
@noahgildersleeve this reads like a separate problem from the original ticket's intent. |
Release notes..
|
|
Give comment above, this feature is now complete |
Is your feature request related to a problem? Please describe.
We need some UI extensions to load before login such internationalization, custom login page, etc..
Describe the solution you'd like
The current solution being explored by the Mapps team is giving the system:unauthenticated access to UI-plugins CRD but the spike is still going on.
Describe alternatives you've considered
N/A
Additional context
Right now, there is no requirement from UI for this issue. But, after the completion of the spike, the Mapps team will edit this issue if there are any UI requirements.
JIRA Issue - https://jira.suse.com/browse/SURE-6315
The text was updated successfully, but these errors were encountered: