Use markRaw()
to signal non reactive data in store
#11097
Merged
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This utilizes
markRaw()
to ensure that certain properties in the Vuex store are marked as "non-reactive".Fixes #11098
Technical notes summary
Upon further review of #11062, I thought that
Object.defineProperty()
was being used, in part, to mark certain properties as "non-reactive" in the Dashboard store.$plugin
,$router
, &$route
really don't need reactivity associated with them.We might want to consider following up in the future to decide if any of these properties belong in the Vuex store at all. We can achieve a similar result by utilizing a singleton or some similar pattern that will allow us to share these definitions throughout Dashboard.
Areas or cases that should be tested
Anything that accesses the $router, $route, or $plugin states stored in the store.
Checklist