Harvester shell integration - bump chron libraries #12349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
|
Can we also run |
a110605
reviewed
Oct 25, 2024
| return this.t('generic.invalidCron'); | ||
| } | ||
| try { | ||
| const hint = cronstrue.toString(this.value || ''); | ||
| const hint = cronstrue.toString(this.value as string || ''); |
There was a problem hiding this comment.
I added { verbose: true } in harvester PR#1103
const hint = cronstrue.toString(this.value, { verbose: true });
Do you want to add it as well ?
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
nwmac
added
the
shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to #12347
Occurred changes and/or fixed issues
Technical notes summary
Some new features in Harvester require newer chron lib versions.
Areas or cases that should be tested
Areas which could experience regressions
CronJobpage.Screenshot/Video
Checklist