Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.9.5] RKE2 cluster provision: Data Directories should not be editable after creation #12619

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

aalves08
Copy link
Member

Summary

Fixes #12617

Occurred changes and/or fixed issues

  • Updated UI for Data Directories to match v2.10 (also takes into account k8s version type when creating the base k8s distro folder from default)
  • disable Data Directories inputs in edit mode
  • update unit tests

Technical notes summary

Areas or cases that should be tested

  • create a cluster with some Data Directories config (RKE2)
  • edit that cluster and check that inputs are disabled and radio options are hidden

Areas which could experience regressions

Screenshot/Video

UI before

before_CREATE before_EDIT

UI after
after_EDIT
1_after_CREATE
2_after_CREATE
3_after_CREATE

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.5 milestone Nov 15, 2024
@aalves08 aalves08 self-assigned this Nov 15, 2024
@aalves08 aalves08 changed the base branch from master to release-2.9 November 15, 2024 11:45
@aalves08 aalves08 requested a review from momesgin November 15, 2024 11:45
@aalves08
Copy link
Member Author

FYI @nwmac , I've updated the UI in 2.9.x to match 2.10 and 2.11

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 6a92a26 into rancher:release-2.9 Nov 15, 2024
3 checks passed
rak-phillip pushed a commit to rak-phillip/dashboard that referenced this pull request Nov 18, 2024
rak-phillip added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backport v2.9.5] RKE2 cluster provision: Data Directories should not be editable after creation
2 participants