Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation] - Check default limit values in UI while creating a Pod with the Form #12727

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[Automation] - Check default limit values in UI while creating a Pod with the Form #12727

merged 1 commit into from
Dec 3, 2024

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Dec 2, 2024 •
edited
Loading

Summary

Fixes # rancher/qa-tasks#1546

Occurred changes and/or fixed issues

Adding POs and test to create a pod and validate default placeholders in the pod resources.

Technical notes summary

Adding E2E test for creating a pod using the UI form

Areas or cases that should be tested

E2E tests execution

Areas which could experience regressions

CI

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac changed the title Check default limit values in UI while creating a Pod with the Form [Automation] - Check default limit values in UI while creating a Pod with the Form Dec 2, 2024
@izaac izaac requested a review from yonasberhe23 December 3, 2024 16:00
@izaac izaac added this to the v2.11.0 milestone Dec 3, 2024
@izaac izaac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 3, 2024
@izaac izaac marked this pull request as ready for review December 3, 2024 16:04
@izaac izaac force-pushed the container_limits branch 5 times, most recently from 2b483a7 to d4d0102 Compare December 3, 2024 18:17
@izaac izaac force-pushed the container_limits branch 2 times, most recently from b0dcc72 to 9175440 Compare December 3, 2024 20:45
@yonasberhe23 yonasberhe23 self-requested a review December 3, 2024 20:46
yonasberhe23
yonasberhe23 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@izaac
Copy link
Contributor Author

izaac commented Dec 3, 2024

fixed lint errors 🫤

@izaac izaac merged commit 25c5cac into rancher:master Dec 3, 2024
31 checks passed
@izaac izaac deleted the container_limits branch December 3, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonasberhe23 yonasberhe23 yonasberhe23 approved these changes

Assignees

@izaac izaac

Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@izaac @yonasberhe23