Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vue-template-complier dependency #12760

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove vue-template-complier dependency #12760

merged 1 commit into from
Dec 5, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Dec 3, 2024 •
edited
Loading

Summary

This removes the unused vue-template-compiler; it is no longer required in Vue3 projects

Fixes #12751

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.11.0 milestone Dec 3, 2024
@rak-phillip rak-phillip marked this pull request as draft December 3, 2024 23:23
@rak-phillip
Remove vue-template-compiler dependency from Dashboard
6b05ab9 
`vue-template-compiler` is required for Vue2 projects. Dashboard has moved on to Vue3 and this dependency is no longer needed.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip force-pushed the chore/12751-component-deps branch from 9626b09 to 6b05ab9 Compare December 5, 2024 18:00
@rak-phillip rak-phillip requested a review from cnotv December 5, 2024 18:00
@rak-phillip rak-phillip marked this pull request as ready for review December 5, 2024 18:01
@rak-phillip rak-phillip changed the title Chore/12751 component deps Remove vue-template-complier dependency Dec 5, 2024
cnotv
cnotv approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit c137a33 into rancher:master Dec 5, 2024
35 checks passed
@rak-phillip rak-phillip deleted the chore/12751-component-deps branch December 5, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv cnotv approved these changes

@codyrancher codyrancher Awaiting requested review from codyrancher

Assignees

@rak-phillip rak-phillip

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Review and clean dependencies for Rancher Components
2 participants
@rak-phillip @cnotv