Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin chrome version #12834

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

yonasberhe23
Copy link
Contributor

Summary

Fixes ##11836

  • Unpinned Chrome version
  • Moved Can navigate to release notes page for latest Rancher version to run last; The test clicks on a link that opens a new tab which is causing issues with subsequent tests (once we are able to upgrade our Cypress version, test order will not matter).

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 merged commit 08da383 into rancher:master Dec 6, 2024
32 checks passed
@yonasberhe23 yonasberhe23 deleted the chrome_version_unpin branch December 6, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants