[backport 2.10] Virtualization Management, show warning message if there are no compatible Harvester versions #12851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
…ith Rancher Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
backport-12640-2
branch
from
58f0710 to
020b063
Compare
richard-cox
reviewed
Dec 10, 2024
| @@ -62,6 +62,7 @@ export default { | |||
|
|
|||
| this.hciClusters = hash.hciClusters; | |||
| this.mgmtClusters = hash.mgmtClusters; | |||
| this.kubeVersion = hash.mgmtClusters.find((c) => c.id === 'local')?.kubernetesVersionBase || ''; | |||
There was a problem hiding this comment.
this would be a minor performance issue.
there's a getter to find a specific resource by id (the cache has all resources mapped by id). think it's <store>/byId
|
@richard-cox @aalves08 I pushed the requested changes, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributes to #12688
Occurred changes and/or fixed issues
We noticed that the latest version Harvester version is installed ignoring the compatibility, in case of there are no compatible versions.
Technical notes summary
We want to show a warning message in case the Harvester installation fails due to missing compatible Harvester versions with Rancher.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Before
After
Checklist