Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualization Management, show warning message if there are no compatible Harvester versions #12852

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

torchiaf
Copy link
Member

Summary

Contributes to #12640

Occurred changes and/or fixed issues

We noticed that the latest version Harvester version is installed ignoring the compatibility, in case of there are no compatible versions.

Technical notes summary

We want to show a warning message in case the Harvester installation fails due to missing compatible Harvester versions with Rancher.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Before

image

After

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf added this to the v2.11.0 milestone Dec 10, 2024
@torchiaf torchiaf requested a review from aalves08 December 11, 2024 09:59
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
…ith Rancher

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf merged commit 6e34696 into rancher:master Dec 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants