Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing check to template part so that workspace switcher is show… #7216

Merged
merged 2 commits into from
Oct 19, 2022
Merged

add missing check to template part so that workspace switcher is show… #7216

merged 2 commits into from
Oct 19, 2022

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Oct 18, 2022 •
edited by zube bot
Loading

Fixes #7213

  • add missing check to template part so that workspace switcher is shown on an blank cluster

@aalves08 aalves08 added this to the v2.7.0 milestone Oct 18, 2022
@aalves08 aalves08 self-assigned this Oct 18, 2022
richard-cox
richard-cox approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the v-if to a computed property, if that looks good to you (and gates pass) feel free to merge

@aalves08
Copy link
Member Author

gave a it a quick test again... LGTM

@aalves08 aalves08 merged commit 0b463f7 into rancher:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Missing namespace selector on continuous delivery page
2 participants
@aalves08 @richard-cox