-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed RKE cluster being shown as Imported #9868
Conversation
@eva-vashkevich Just curious what happens to imported k3s clusters, as of my understanding I actually just read the old comment about the workaround, so based on that |
@momesgin I've checked and it does identify imported k3 correctly, though your comment made me re-check rke2 case and I was missing identifying DO correctly, so thank you. |
happy that it helped somehow 😆 |
Summary
Fixes #6836
We were not identifying RKE1 clusters correctly.
Occurred changes and/or fixed issues
Changed the way we identify cluster provisioner type to recognize RKE1 clusters correctly and moved the logic to determine if cluster is imported from the Cluster Provider component to the model for better consistency.
Technical notes summary
Areas or cases that should be tested
Cluster management and Home pages should be showing correct "provider" field for each cluster.
Cluster edit should be showing correct fields.
Tested using Chrome 117.0.5938.132
Tested localy:
RKE1 is showing correct info as local and as imported clusters.
K3s is showing correct info as local, created through UI and imported clusters.
RKE2 is showing correct info as local and imported clusters.
AKS is showing correct info as created and imported cluster.
Areas which could experience regressions
Cluster edit might be affected.
Screenshot/Video