Adds e2e test to check that bundledeployments are deleted #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
e2e-bundledeployments-finalizers
branch
22 times, most recently
from
f028bb8
to
bc2c4ff
Compare
This adds a new test to check that when applying a gitrepo that targets based on labels it deploys/deletes the bundledeployment depending if the label for targetting is present or not in the downstream cluster This is related to: rancher#2820 Refers to: rancher#2768 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
e2e-bundledeployments-finalizers
branch
from
bc2c4ff
to
83d366c
Compare
weyfonk
approved these changes
Sep 16, 2024
| }) | ||
|
|
||
| JustBeforeEach(func() { | ||
| err := testenv.ApplyTemplate(k.Namespace(env.ClusterRegistrationNamespace), testenv.AssetPath(asset), data) |
There was a problem hiding this comment.
nit: this could most likely be made more lightweight by testing direct creation of a bundle, skipping GitRepo.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new test to check that when applying a gitrepo that targets based on labels it deploys/deletes the bundledeployment depending if the label for targetting is present or not in the downstream cluster
This is related to: #2820
Refers to: #2768