Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate k3d dev scripts for upstream/downstream #3166

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

manno
Copy link
Member

@manno manno commented Dec 20, 2024

  • support PORT_OFFSET for upstream in both, to avoid conflicts with host ports
  • for simplicity downstreams always have a number in their name

The setup-k3d script exposes four kinds of ports:

  • API server port
  • tls port
  • service ports
  • optional: metric ports

* support PORT_OFFSET for upstream in both, to avoid conflicts with
  host ports
* for simplicity downstreams always have a number in their name
@manno manno requested a review from a team as a code owner December 20, 2024 11:16
@manno manno merged commit d0829d7 into main Dec 20, 2024
12 checks passed
@manno manno deleted the dev-separate-downstream-k3d branch December 20, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants