Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Continue with bundle creation even if one chart can't be downloaded (SURE-7399) #3272

Closed
wants to merge 5 commits into from
Closed

WIP: Continue with bundle creation even if one chart can't be downloaded (SURE-7399) #3272

wants to merge 5 commits into from

Conversation

p-se
Copy link
Contributor

@p-se p-se commented Jan 29, 2025

  • Fix image import for downstream clusters
  • wip
  • Update
  • Update BundleDeployment status
  • Copy urlError in Bundle annotations to status

p-se added 5 commits January 24, 2025 13:28
@p-se
Fix image import for downstream clusters
d9a0db2 
when more than one downstream clusters is deployed.

The change from `downstream` to `downstream1` resulted in a lookup for
downstream clusters where the name contains `downstream1`.

Regression introdued in de40675.
@p-se
wip
b280501
@p-se
Update
ba637ce
@p-se
Update BundleDeployment status
3fc985b 
- Copy annotation from Bundle to BundleDeployment on creation time if the
  BundleDeployment does not have any resources and the urlError exists
  in the annotations of the Bundle.
- Set the status to non-ready if the BundleDeployment has no resources.
  Also in that case, check the annotations of the BundleDeployment for
  an urlError and set it as the status of the BundleDeployment if it
  exist.

TODO for some reason the status of the BundleDeployment isn't copied to
the Bundle and GitRepo. Instead, they just report the BundleDeployment
as non-ready. I assume this is because they compute the status
differently than the agent does. But perhaps that is acceptable?
@p-se
Copy urlError in Bundle annotations to status
3e31e7f 
This leads to the GitRepo controller picking up the status message from
the Bundle, so that the GitRepo resource also shows the same error that
is shown in the Bundle.

This works without having to further adapt the GitRepo but likely is the
same mechanism that copies the template errors from the Bundle to the
GitRepo.
@p-se p-se closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p-se