Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.8] fix: Replace unapproved GH Actions with approved ones #490

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

yiannistri
Copy link
Contributor

What this PR does / why we need it:

Replace unapproved GH Actions with approved ones. To enhance security, the 3rd-party GH Action used to install kind is pinned to a commit SHA. Note that dependabot will update both the commit SHA and the human-readable value next to it.

Which issue(s) this PR fixes
Issue rancher/highlander#89

Special notes for your reviewer:

  • actions/checkout has been updated to v4 to eliminate Node runtime version warnings
  • actions/setup-go has been updated to v5 to eliminate Node runtime version warnings
  • Upon checkout, credentials are not being persisted since the git commands will occur on a different repo (bot's fork)

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@yiannistri yiannistri added github_actions Pull requests that update GitHub Actions code area/ci labels Jun 3, 2024
@yiannistri yiannistri marked this pull request as ready for review June 3, 2024 12:39
@yiannistri yiannistri requested a review from a team as a code owner June 3, 2024 12:39
@mjura mjura merged commit 85c8097 into rancher:release-v2.8 Jun 3, 2024
7 checks passed
@yiannistri yiannistri deleted the 89-migrate-gha-release-v2.8 branch June 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants