Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from drone to Github Actions for 2.9 #1402

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mitulshah-suse
Copy link
Contributor

@mitulshah-suse mitulshah-suse commented May 22, 2024

Move from drone to GHA for dev-v2.9 branch
ref: rancher/rancher#45375

Notes:

  • This uses the ubuntu 22.04 patched runners with cgroupsv1 where prov tests are passing. It still has flaky test failures and increasing timeout for them in rancher repo will likely reduce flakiness further. ex: https://github.com/rancher/kontainer-driver-metadata/actions/runs/9657116486
  • Have updated the version range for prov tests from 27-30, since 1.25 and 1.26 support is being removed from 2.9 and 1.30 support is being added
  • Have removed most of the drone variables which were being used except for DRONE_BUILD_NUMBER. That one is being used in rancher/rancher prov tests scripts, so cannot remove that until rancher repo does the same.
  • Removed regsync check from validate step

Any change in the rancher/rancher repo done for prov tests will directly impact KDM prov tests and might require further changes

@mitulshah-suse mitulshah-suse force-pushed the move-to-gha-2.9 branch 2 times, most recently from ace2981 to 0810ee2 Compare May 22, 2024 10:05
@Sahota1225 Sahota1225 requested a review from a team May 22, 2024 18:20
@jakefhyde jakefhyde self-requested a review May 22, 2024 19:15
Copy link
Contributor

@jakefhyde jakefhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits/questions.

.github/workflows/workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/provisioning-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/provisioning-tests.yaml Outdated Show resolved Hide resolved
@mitulshah-suse mitulshah-suse force-pushed the move-to-gha-2.9 branch 12 times, most recently from b4f3fa5 to 891aaaf Compare May 30, 2024 08:04
@mitulshah-suse mitulshah-suse marked this pull request as draft May 30, 2024 08:05
@mitulshah-suse mitulshah-suse force-pushed the move-to-gha-2.9 branch 12 times, most recently from b1a37c3 to a979908 Compare June 3, 2024 07:54
@mitulshah-suse mitulshah-suse force-pushed the move-to-gha-2.9 branch 13 times, most recently from 8572095 to 4fc2eda Compare June 24, 2024 07:18
@mitulshah-suse mitulshah-suse force-pushed the move-to-gha-2.9 branch 2 times, most recently from 6313120 to 297c624 Compare June 26, 2024 10:30
@mitulshah-suse mitulshah-suse requested review from kinarashah, jakefhyde and a team June 26, 2024 10:40
@mitulshah-suse mitulshah-suse marked this pull request as ready for review June 26, 2024 10:40
scripts/version Outdated Show resolved Hide resolved
scripts/provisioning-tests Outdated Show resolved Hide resolved
Dockerfile.dapper Show resolved Hide resolved
@snasovich snasovich merged commit 6430a03 into rancher:dev-v2.9 Jul 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants