[dev-v2.6] Metrics server fix #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayandas
force-pushed
the
metric-server-fix-dev-v2.6
branch
from
9671320 to
4733f28
Compare
rayandas
force-pushed
the
metric-server-fix-dev-v2.6
branch
from
4733f28 to
d7c37b4
Compare
rayandas
force-pushed
the
metric-server-fix-dev-v2.6
branch
2 times, most recently
from
2941aaf to
ef62559
Compare
|
@kinarashah I added the changes from #984 to this PR. It should be good to go. |
kinarashah
requested changes
Oct 13, 2022
There was a problem hiding this comment.
@rayandas this is updating v1.22.13-rancher1-1 with new metrics-server image, but we need to add a new v1.22.15-rancher1-1 for this - same as v2.7.0 PR. Also, this is why drone is failing right now because an already released k8s version v1.22.13 got updated.
rayandas
force-pushed
the
metric-server-fix-dev-v2.6
branch
from
ef62559 to
d70b9dd
Compare
kinarashah
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: rancher/rancher#39078
Depends on: #967