Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the helper pod more range of MCS categories #402

Merged
merged 1 commit into from
May 27, 2024

Conversation

galal-hussein
Copy link
Contributor

The fix will provide the helper pod with more MCS categories which will fix the issue with having two pods trying to access shared files (the helper setup pod, and the helper delete pod)

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@derekbit
Copy link
Member

@galal-hussein
Can you give us more context and purpose of the PR? Thank you.

@galal-hussein
Copy link
Contributor Author

@derekbit I have linked the related issue which this PR solves, you can also check out my latest comment k3s-io/k3s#10130 (comment) it describes the problem and the solution in the PR

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@derekbit derekbit merged commit c4dc309 into rancher:master May 27, 2024
1 check failed
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Jun 5, 2024
…7 ) (#4774)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[local-path-provisioner](https://github.com/rancher/local-path-provisioner)
| patch | `v0.0.26` -> `v0.0.27` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/local-path-provisioner
(local-path-provisioner)</summary>

###
[`v0.0.27`](https://github.com/rancher/local-path-provisioner/releases/tag/v0.0.27):
Local Path Provisioner v0.0.27

[Compare
Source](https://github.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27)

#### What's Changed

- Repair code example in storageClass description. by
[@&#8203;c4lliope](https://github.com/c4lliope) in
[rancher/local-path-provisioner#368
- Update README.md to 0.26 by
[@&#8203;e-minguez](https://github.com/e-minguez) in
[rancher/local-path-provisioner#373
- Update README.md,rm /manager by
[@&#8203;terryzwt](https://github.com/terryzwt) in
[rancher/local-path-provisioner#379
- Fix duplicate labels by
[@&#8203;runningman84](https://github.com/runningman84) in
[rancher/local-path-provisioner#393
- drone: remove s390x support by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#391
- Feature/multiple storage classes by
[@&#8203;meln5674](https://github.com/meln5674) in
[rancher/local-path-provisioner#361
- Remove duplicate labels and add ability to set helperpod resource
requests/limits by [@&#8203;visokoo](https://github.com/visokoo) in
[rancher/local-path-provisioner#394
- Automatic reloading of the helper pod manifest by the provisioner by
[@&#8203;js185692](https://github.com/js185692) in
[rancher/local-path-provisioner#399
- Add support for custom path patterns by
[@&#8203;AlbanBedel](https://github.com/AlbanBedel) in
[rancher/local-path-provisioner#385
- adding pvc with node name example by
[@&#8203;sebastianohl](https://github.com/sebastianohl) in
[rancher/local-path-provisioner#382
- Add e2e test for custom path patterns by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#404
- Give the helper pod more range of MCS categories by
[@&#8203;galal-hussein](https://github.com/galal-hussein) in
[rancher/local-path-provisioner#402
- Fix: Chart.yaml file is missing on helm install by
[@&#8203;jamshidi799](https://github.com/jamshidi799) in
[rancher/local-path-provisioner#388
- drone: disable e2e test by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#405
- Allow customizing helper pod by
[@&#8203;justusbunsi](https://github.com/justusbunsi) in
[rancher/local-path-provisioner#365
- test: use reclaimPolicy Delete instead by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#406
- chart: fix pathPattern by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#409

#### New Contributors

- [@&#8203;c4lliope](https://github.com/c4lliope) made their first
contribution in
[rancher/local-path-provisioner#368
- [@&#8203;e-minguez](https://github.com/e-minguez) made their first
contribution in
[rancher/local-path-provisioner#373
- [@&#8203;terryzwt](https://github.com/terryzwt) made their first
contribution in
[rancher/local-path-provisioner#379
- [@&#8203;runningman84](https://github.com/runningman84) made their
first contribution in
[rancher/local-path-provisioner#393
- [@&#8203;visokoo](https://github.com/visokoo) made their first
contribution in
[rancher/local-path-provisioner#394
- [@&#8203;AlbanBedel](https://github.com/AlbanBedel) made their first
contribution in
[rancher/local-path-provisioner#385
- [@&#8203;sebastianohl](https://github.com/sebastianohl) made their
first contribution in
[rancher/local-path-provisioner#382
- [@&#8203;galal-hussein](https://github.com/galal-hussein) made their
first contribution in
[rancher/local-path-provisioner#402
- [@&#8203;jamshidi799](https://github.com/jamshidi799) made their
first contribution in
[rancher/local-path-provisioner#388
- [@&#8203;justusbunsi](https://github.com/justusbunsi) made their
first contribution in
[rancher/local-path-provisioner#365

**Full Changelog**:
rancher/local-path-provisioner@v0.0.26...v0.0.27

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Jun 5, 2024
…7 ) (#4773)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[local-path-provisioner](https://github.com/rancher/local-path-provisioner)
| patch | `v0.0.26` -> `v0.0.27` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rancher/local-path-provisioner
(local-path-provisioner)</summary>

###
[`v0.0.27`](https://github.com/rancher/local-path-provisioner/releases/tag/v0.0.27):
Local Path Provisioner v0.0.27

[Compare
Source](https://github.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27)

#### What's Changed

- Repair code example in storageClass description. by
[@&#8203;c4lliope](https://github.com/c4lliope) in
[rancher/local-path-provisioner#368
- Update README.md to 0.26 by
[@&#8203;e-minguez](https://github.com/e-minguez) in
[rancher/local-path-provisioner#373
- Update README.md,rm /manager by
[@&#8203;terryzwt](https://github.com/terryzwt) in
[rancher/local-path-provisioner#379
- Fix duplicate labels by
[@&#8203;runningman84](https://github.com/runningman84) in
[rancher/local-path-provisioner#393
- drone: remove s390x support by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#391
- Feature/multiple storage classes by
[@&#8203;meln5674](https://github.com/meln5674) in
[rancher/local-path-provisioner#361
- Remove duplicate labels and add ability to set helperpod resource
requests/limits by [@&#8203;visokoo](https://github.com/visokoo) in
[rancher/local-path-provisioner#394
- Automatic reloading of the helper pod manifest by the provisioner by
[@&#8203;js185692](https://github.com/js185692) in
[rancher/local-path-provisioner#399
- Add support for custom path patterns by
[@&#8203;AlbanBedel](https://github.com/AlbanBedel) in
[rancher/local-path-provisioner#385
- adding pvc with node name example by
[@&#8203;sebastianohl](https://github.com/sebastianohl) in
[rancher/local-path-provisioner#382
- Add e2e test for custom path patterns by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#404
- Give the helper pod more range of MCS categories by
[@&#8203;galal-hussein](https://github.com/galal-hussein) in
[rancher/local-path-provisioner#402
- Fix: Chart.yaml file is missing on helm install by
[@&#8203;jamshidi799](https://github.com/jamshidi799) in
[rancher/local-path-provisioner#388
- drone: disable e2e test by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#405
- Allow customizing helper pod by
[@&#8203;justusbunsi](https://github.com/justusbunsi) in
[rancher/local-path-provisioner#365
- test: use reclaimPolicy Delete instead by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#406
- chart: fix pathPattern by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#409

#### New Contributors

- [@&#8203;c4lliope](https://github.com/c4lliope) made their first
contribution in
[rancher/local-path-provisioner#368
- [@&#8203;e-minguez](https://github.com/e-minguez) made their first
contribution in
[rancher/local-path-provisioner#373
- [@&#8203;terryzwt](https://github.com/terryzwt) made their first
contribution in
[rancher/local-path-provisioner#379
- [@&#8203;runningman84](https://github.com/runningman84) made their
first contribution in
[rancher/local-path-provisioner#393
- [@&#8203;visokoo](https://github.com/visokoo) made their first
contribution in
[rancher/local-path-provisioner#394
- [@&#8203;AlbanBedel](https://github.com/AlbanBedel) made their first
contribution in
[rancher/local-path-provisioner#385
- [@&#8203;sebastianohl](https://github.com/sebastianohl) made their
first contribution in
[rancher/local-path-provisioner#382
- [@&#8203;galal-hussein](https://github.com/galal-hussein) made their
first contribution in
[rancher/local-path-provisioner#402
- [@&#8203;jamshidi799](https://github.com/jamshidi799) made their
first contribution in
[rancher/local-path-provisioner#388
- [@&#8203;justusbunsi](https://github.com/justusbunsi) made their
first contribution in
[rancher/local-path-provisioner#365

**Full Changelog**:
rancher/local-path-provisioner@v0.0.26...v0.0.27

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
sp3nx0r pushed a commit to sp3nx0r/homelab that referenced this pull request Jun 22, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[local-path-provisioner](https://github.com/rancher/local-path-provisioner)
| patch | `v0.0.26` -> `v0.0.28` |

---

### Release Notes

<details>
<summary>rancher/local-path-provisioner
(local-path-provisioner)</summary>

###
[`v0.0.28`](https://github.com/rancher/local-path-provisioner/releases/tag/v0.0.28):
Local Path Provisioner v0.0.28

[Compare
Source](https://github.com/rancher/local-path-provisioner/compare/v0.0.27...v0.0.28-rc1)

#### What's Changed

- Migrate CI to github Actions by
[@&#8203;mantissahz](https://github.com/mantissahz) in
[rancher/local-path-provisioner#403
- fix(ci): allow to read docker hub secret by
[@&#8203;mantissahz](https://github.com/mantissahz) in
[rancher/local-path-provisioner#412
- Revert "Give the helper pod more range of MCS categories" by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#421
- Temporarily disable TestPodWithMultipleStorageClasses by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#423
- Move helperPod namespace into metadata by
[@&#8203;justusbunsi](https://github.com/justusbunsi) in
[rancher/local-path-provisioner#425

#### New Contributors

- [@&#8203;justusbunsi](https://github.com/justusbunsi) made their
first contribution in
[rancher/local-path-provisioner#365
- [@&#8203;mantissahz](https://github.com/mantissahz) made their first
contribution in
[rancher/local-path-provisioner#403

**Full Changelog**:
rancher/local-path-provisioner@v0.0.27...v0.0.28

###
[`v0.0.27`](https://github.com/rancher/local-path-provisioner/releases/tag/v0.0.27):
Local Path Provisioner v0.0.27

[Compare
Source](https://github.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27)

#### What's Changed

- Repair code example in storageClass description. by
[@&#8203;c4lliope](https://github.com/c4lliope) in
[rancher/local-path-provisioner#368
- Update README.md to 0.26 by
[@&#8203;e-minguez](https://github.com/e-minguez) in
[rancher/local-path-provisioner#373
- Update README.md,rm /manager by
[@&#8203;terryzwt](https://github.com/terryzwt) in
[rancher/local-path-provisioner#379
- Fix duplicate labels by
[@&#8203;runningman84](https://github.com/runningman84) in
[rancher/local-path-provisioner#393
- drone: remove s390x support by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#391
- Feature/multiple storage classes by
[@&#8203;meln5674](https://github.com/meln5674) in
[rancher/local-path-provisioner#361
- Remove duplicate labels and add ability to set helperpod resource
requests/limits by [@&#8203;visokoo](https://github.com/visokoo) in
[rancher/local-path-provisioner#394
- Automatic reloading of the helper pod manifest by the provisioner by
[@&#8203;js185692](https://github.com/js185692) in
[rancher/local-path-provisioner#399
- Add support for custom path patterns by
[@&#8203;AlbanBedel](https://github.com/AlbanBedel) in
[rancher/local-path-provisioner#385
- adding pvc with node name example by
[@&#8203;sebastianohl](https://github.com/sebastianohl) in
[rancher/local-path-provisioner#382
- Add e2e test for custom path patterns by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#404
- Give the helper pod more range of MCS categories by
[@&#8203;galal-hussein](https://github.com/galal-hussein) in
[rancher/local-path-provisioner#402
- Fix: Chart.yaml file is missing on helm install by
[@&#8203;jamshidi799](https://github.com/jamshidi799) in
[rancher/local-path-provisioner#388
- drone: disable e2e test by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#405
- Allow customizing helper pod by
[@&#8203;justusbunsi](https://github.com/justusbunsi) in
[rancher/local-path-provisioner#365
- test: use reclaimPolicy Delete instead by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#406
- chart: fix pathPattern by
[@&#8203;derekbit](https://github.com/derekbit) in
[rancher/local-path-provisioner#409

#### New Contributors

- [@&#8203;c4lliope](https://github.com/c4lliope) made their first
contribution in
[rancher/local-path-provisioner#368
- [@&#8203;e-minguez](https://github.com/e-minguez) made their first
contribution in
[rancher/local-path-provisioner#373
- [@&#8203;terryzwt](https://github.com/terryzwt) made their first
contribution in
[rancher/local-path-provisioner#379
- [@&#8203;runningman84](https://github.com/runningman84) made their
first contribution in
[rancher/local-path-provisioner#393
- [@&#8203;visokoo](https://github.com/visokoo) made their first
contribution in
[rancher/local-path-provisioner#394
- [@&#8203;AlbanBedel](https://github.com/AlbanBedel) made their first
contribution in
[rancher/local-path-provisioner#385
- [@&#8203;sebastianohl](https://github.com/sebastianohl) made their
first contribution in
[rancher/local-path-provisioner#382
- [@&#8203;galal-hussein](https://github.com/galal-hussein) made their
first contribution in
[rancher/local-path-provisioner#402
- [@&#8203;jamshidi799](https://github.com/jamshidi799) made their
first contribution in
[rancher/local-path-provisioner#388
- [@&#8203;justusbunsi](https://github.com/justusbunsi) made their
first contribution in
[rancher/local-path-provisioner#365

**Full Changelog**:
rancher/local-path-provisioner@v0.0.26...v0.0.27

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/sp3nx0r/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants