Update services.go to address nil pointer bug and also do not enable …

…inference deployment automatically
rancher · Nov 28, 2022 · 20d11f5 · 20d11f5
1 parent 8660527
commit 20d11f5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/resources/opnicluster/services.go b/pkg/resources/opnicluster/services.go
@@ -690,7 +690,7 @@ func deploymentState(enabled *bool) reconciler.DesiredState {
 }
 
 func deploymentStateDisabled(enabled *bool) reconciler.DesiredState {
-	if enabled != nil || *enabled {
+	if lo.FromPtrOr(enabled, false) {
 		return reconciler.StatePresent
 	}
 	return reconciler.StateAbsent
@@ -733,7 +733,7 @@ func (r *Reconciler) inferenceDeployment() (runtime.Object, reconciler.DesiredSt
 	})
 
 	insertHyperparametersVolume(deployment, "nulog")
-	return deployment, deploymentState(r.spec.Services.Inference.Enabled), nil
+	return deployment, deploymentStateDisabled(r.spec.Services.Inference.Enabled), nil
 }
 
 func (r *Reconciler) drainDeployment() (runtime.Object, reconciler.DesiredState, error) {