Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cert & alerting fixes #1793

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Cert & alerting fixes #1793

merged 6 commits into from
Oct 27, 2023

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Oct 25, 2023 •
edited
Loading

  • Fixed a change lost in one of the rebases; cluster drivers are only responsible for finding the alerting cluster peers, not initializing clients
  • Fixed a bug where an initial install of the alerting cluster would always result in a TLS error
  • Fixed a missing edge case where prometheus rules not being present in the metrics backend resulted in an Ok status instead of Pending
  • Fixed a UI bug that made it impossible to delete alert conditions
  • Improved the detection of the existence of rule objects in cortex from the alerting plugin

@alexandreLamarre alexandreLamarre marked this pull request as ready for review October 27, 2023 17:17
@alexandreLamarre
Copy link
Contributor Author

alexandreLamarre commented Oct 27, 2023 •
edited
Loading

This has a breaking change with evaluating Prometheus based alert status. Prometheus rules may show up as Pending : insufficient metadata -- uninstalling and reinstalling the alerting cluster will properly index the Prometheus based alerts

kralicky
kralicky previously approved these changes Oct 27, 2023
View reviewed changes
jaehnri
jaehnri reviewed Oct 27, 2023
View reviewed changes
plugins/alerting/pkg/alerting/drivers/alerting_manager/options.go
@@ -16,4 +18,5 @@ type AlertingDriverOptions struct {
InternalRoutingKey string `option:"internalRoutingKey"`
AlertingOptions *shared.AlertingClusterOptions `option:"alertingOptions"`
Subscribers []chan alertingClient.AlertingClient `option:"subscribers"`
TlsConfig *tls.Config `option:"tlsConfig"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't wanna be that guy but acronyms should be in consistent case -> TLSConfig

@alexandreLamarre alexandreLamarre merged commit 9087308 into main Oct 27, 2023
2 checks passed
@alexandreLamarre alexandreLamarre deleted the cert-fixes branch October 27, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kralicky kralicky kralicky approved these changes

@jaehnri jaehnri jaehnri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandreLamarre @kralicky @jaehnri