Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cortex Service Discovery improvements & Disable SLO API #493

Merged
merged 10 commits into from
Aug 12, 2022
Merged

Cortex Service Discovery improvements & Disable SLO API #493

merged 10 commits into from
Aug 12, 2022

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Aug 11, 2022 •
edited
Loading

Implement cortex plugin functionality for doing the necessary service discovery for the following UX :

UI proposal

Essentially adding :

  • Enumerating series by service & cluster, & filtering/processing out unimportant series
  • Creating label sets, which represents all (label key, label value) pairs for a given service on a given metric. (These corresponds to what the user would know as events)
  • Removing SLO functionality pending new user input & extended service discovery backend

@alexandreLamarre alexandreLamarre marked this pull request as ready for review August 11, 2022 19:55
@alexandreLamarre alexandreLamarre linked an issue Aug 11, 2022 that may be closed by this pull request
Service Discovery improvements #494
Closed
dbason
dbason suggested changes Aug 11, 2022
View reviewed changes
pkg/metrics/unmarshal/unmarshal.go Show resolved Hide resolved
plugins/cortex/pkg/cortex/prometheus_util.go Outdated Show resolved Hide resolved
plugins/slo/pkg/slo/simple.go Show resolved Hide resolved
@alexandreLamarre alexandreLamarre merged commit ea9546e into main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbason dbason dbason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Discovery improvements
2 participants
@alexandreLamarre @dbason