Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge After 0.6 Release] Alerting Admin API + Dynamic Routing Fix + Agentv2 disconnect #663

Merged
merged 36 commits into from
Oct 25, 2022
Merged

[Merge After 0.6 Release] Alerting Admin API + Dynamic Routing Fix + Agentv2 disconnect #663

merged 36 commits into from
Oct 25, 2022

Conversation

alexandreLamarre
Copy link
Contributor

No description provided.

@alexandreLamarre alexandreLamarre marked this pull request as ready for review October 14, 2022 18:02
@alexandreLamarre alexandreLamarre changed the title Alerting Admin API [Merge After 0.6 Release] Alerting Admin API Oct 14, 2022
This was linked to issues Oct 15, 2022
Alerting Backend : admin Install #665
Closed
Fix Alerting backend Dependency injection #668
Closed
Fix routing tree to not restrict to single endpoint nodes #670
Closed
Fix Alerting Http Client #671
Closed
Alert Endpoint : Dynamically updating endpoint info will not always update conditions that use that endpoint #669
Closed
@alexandreLamarre alexandreLamarre force-pushed the compute-alerts branch 2 times, most recently from 2d39ac2 to ec9612c Compare October 20, 2022 19:15
@alexandreLamarre alexandreLamarre linked an issue Oct 21, 2022 that may be closed by this pull request
Opni Agent Disconnect with agentv2 #666
Closed
@alexandreLamarre alexandreLamarre changed the title [Merge After 0.6 Release] Alerting Admin API [Merge After 0.6 Release] Alerting Admin API + Dynamic Routing Fix + Agentv2 disconnect Oct 21, 2022
@alexandreLamarre alexandreLamarre force-pushed the compute-alerts branch 2 times, most recently from a50d45a to 59e393d Compare October 21, 2022 16:19
kralicky
kralicky requested changes Oct 21, 2022
View reviewed changes
pkg/alerting/backend/backend.go Outdated Show resolved Hide resolved
pkg/health/listener.go Show resolved Hide resolved
pkg/health/nats_stream.go Outdated Show resolved Hide resolved
pkg/opni/commands/alerting.go Outdated Show resolved Hide resolved
pkg/resources/gateway/alerting.go Show resolved Hide resolved
pkg/test/environment.go Outdated Show resolved Hide resolved
pkg/test/environment.go Outdated Show resolved Hide resolved
plugins/alerting/pkg/apis/alertops/alertops.proto Outdated Show resolved Hide resolved
plugins/alerting/pkg/apis/server/endpoint/alerting.endpoint.proto Outdated Show resolved Hide resolved
@alexandreLamarre alexandreLamarre force-pushed the compute-alerts branch 2 times, most recently from 7c73fde to 3bb62a6 Compare October 25, 2022 15:48
@alexandreLamarre @kralicky
Refactor storage to storage node
981d29d
@alexandreLamarre @kralicky
Refactor ConfigMapData to RoutingTree
0851293
@alexandreLamarre @kralicky
Fix routing to have multiple nodes and update dynamically, but break …
aa52330 
…everything else
@alexandreLamarre @kralicky
Fix most of the dynamic routing cases in the API
e32f390
@alexandreLamarre @kralicky
bugfixes, edgecase for deleting endpoints, better AlertManager HTTP c…
95803a1 
…lient
@alexandreLamarre @kralicky
new alerting http client fixes
e6f0252
@alexandreLamarre @kralicky
validate api inputs & fix test compilation
da26cad
@alexandreLamarre @kralicky
tidy apis & warnings for updates/deletes that propagate to other reso…
e6a06dc 
…urces
@alexandreLamarre @kralicky
alerting local driver
27c7265
@alexandreLamarre @kralicky
Partial jetstream stream agent disconnect
2ec6915
@alexandreLamarre @kralicky
system disconnect condition node
915f88d
@alexandreLamarre @kralicky
timeline api, disable inner condition logic for testing
859c12f
@alexandreLamarre @kralicky
Fix impl details on conditions, change timeline to post
17d48b1
@alexandreLamarre @kralicky
agentv2 disconnect :)
78d1fea
@alexandreLamarre @kralicky
reindex active agent disconnection trackers when plugin restarts
5c1709a
@alexandreLamarre @kralicky
tidy api code
6ea6732
@alexandreLamarre @kralicky
fixed stuttering issues introduced by new alerting http client
4ef777d
@alexandreLamarre @kralicky
get alerts api struct
ba1d3c2
@alexandreLamarre @kralicky
small bugfixes
31394a1
@alexandreLamarre @kralicky
Fix formatting issues for review
7c38ea5
@alexandreLamarre @kralicky
Tidy stream creation
3e619a9
@alexandreLamarre @kralicky
Add node exporter to test environment
3a0f4b9
@alexandreLamarre @kralicky
Move health/status jetstream logic to plugins/alerting
5a1b465
@alexandreLamarre @kralicky
rename alertingv1alpha to alertingv1
056785f
@alexandreLamarre @kralicky
Implement timeline api, fix order of operations
486b0a5
@kralicky kralicky merged commit c9136c4 into main Oct 25, 2022
@kralicky kralicky deleted the compute-alerts branch October 25, 2022 16:57
@alexandreLamarre alexandreLamarre linked an issue Oct 25, 2022 that may be closed by this pull request
Alerting : Timeline API #714
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kralicky kralicky kralicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexandreLamarre @kralicky