Training gateway plugin #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmartC
force-pushed
the
training-gateway-plugin
branch
from
c930c4d
to
8da205e
Compare
kralicky
requested changes
Oct 26, 2022
|
Overall, need to ensure variable/function/type names follow the Go style guide https://go.dev/doc/effective_go#names |
dbason
suggested changes
Oct 26, 2022
dbason
reviewed
Oct 26, 2022
dbason
suggested changes
Oct 26, 2022
This was referenced Oct 26, 2022
dbason
suggested changes
Oct 26, 2022
dbason
suggested changes
Oct 26, 2022
dbason
suggested changes
Oct 26, 2022
AmartC
force-pushed
the
training-gateway-plugin
branch
2 times, most recently
from
9abdbb1
to
8f7d05b
Compare
dbason
previously approved these changes
Oct 26, 2022
kralicky
requested changes
Oct 27, 2022
plugins/modeltraining/pkg/apis/modeltraining/modeltraining.proto
Outdated
Show resolved
Hide resolved
plugins/modeltraining/pkg/apis/modeltraining/modeltraining.proto
Outdated
Show resolved
Hide resolved
plugins/modeltraining/pkg/apis/modeltraining/modeltraining.proto
Outdated
Show resolved
Hide resolved
plugins/modeltraining/pkg/apis/modeltraining/modeltraining.proto
Outdated
Show resolved
Hide resolved
plugins/modeltraining/pkg/apis/modeltraining/modeltraining.proto
Outdated
Show resolved
Hide resolved
|
Also need to squash and reword similar commits |
AmartC
force-pushed
the
training-gateway-plugin
branch
from
d711254
to
50ecbb9
Compare
dbason
suggested changes
Oct 27, 2022
AmartC
force-pushed
the
training-gateway-plugin
branch
2 times, most recently
from
029d839
to
09d969b
Compare
…1000 records per scroll
AmartC
force-pushed
the
training-gateway-plugin
branch
from
384942f
to
5f51000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the model training plugin for the gateway which will be used by the admin UI service to display workload deployments and log counts and launch model training jobs.