Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config equality logic + simple unit tests #862

Merged
merged 2 commits into from
Dec 15, 2022
Merged

config equality logic + simple unit tests #862

merged 2 commits into from
Dec 15, 2022

Conversation

alexandreLamarre
Copy link
Contributor

No description provided.

This was linked to issues Nov 24, 2022
Invalid comparisons for email receiver equality #858
Closed
Missing equality method/check on pager duty receivers #859
Closed
@alexandreLamarre alexandreLamarre changed the title pager duty equality + simple unit tests pager duty equality/email update in place + simple unit tests Nov 24, 2022
kralicky
kralicky requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@kralicky kralicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor equality checking functions (as discussed on slack)

@alexandreLamarre alexandreLamarre force-pushed the opni-routing-eq-fix branch 3 times, most recently from 023b35b to c06eaec Compare November 29, 2022 21:46
@alexandreLamarre alexandreLamarre changed the title pager duty equality/email update in place + simple unit tests config equality logic + simple unit tests Nov 29, 2022
kralicky
kralicky requested changes Dec 13, 2022
View reviewed changes
pkg/alerting/routing/slack.go Show resolved Hide resolved
pkg/alerting/routing/slack.go Show resolved Hide resolved
@alexandreLamarre alexandreLamarre force-pushed the opni-routing-eq-fix branch 3 times, most recently from f4b77d5 to 03d7a92 Compare December 14, 2022 21:51
kralicky
kralicky previously approved these changes Dec 15, 2022
View reviewed changes
@alexandreLamarre alexandreLamarre merged commit 78d1ae6 into main Dec 15, 2022
@alexandreLamarre alexandreLamarre deleted the opni-routing-eq-fix branch April 18, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kralicky kralicky kralicky approved these changes

@dbason dbason Awaiting requested review from dbason

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing equality method/check on pager duty receivers Invalid comparisons for email receiver equality
2 participants
@alexandreLamarre @kralicky