ephemeral dispatchers & update alert fix #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandreLamarre
commented
Dec 14, 2022
•
alexandreLamarre
commented
- Tidy test alert api with a separate method for creating finite use endpoints
- Fix update alert by validating the redacted request
alexandreLamarre
force-pushed
the
ephemeral-dispatcher
branch
from
c2c35b6
to
0e2f4e9
Compare
kralicky
reviewed
Dec 14, 2022
kralicky
reviewed
Dec 14, 2022
plugins/alerting/pkg/apis/server/endpoint/alerting.endpoint.proto
Outdated
Show resolved
Hide resolved
alexandreLamarre
force-pushed
the
ephemeral-dispatcher
branch
from
0e2f4e9
to
de1b117
Compare
alexandreLamarre
force-pushed
the
ephemeral-dispatcher
branch
from
de1b117
to
b4c8c8c
Compare
kralicky
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.