Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListRules as a command line diagnostic tool #946

Merged
merged 2 commits into from
Jan 5, 2023
Merged

ListRules as a command line diagnostic tool #946

merged 2 commits into from
Jan 5, 2023

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Jan 5, 2023 •
edited
Loading

  • list rules fixes for cortex HA mode
  • multi cluster list support
  • Improved GRPC api :
    • accepts filters
    • returns protobuf message instead of raw bytes
  • CLI for listing & filtering rules

@alexandreLamarre alexandreLamarre marked this pull request as ready for review January 5, 2023 00:11
joshmeranda
joshmeranda approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandreLamarre alexandreLamarre merged commit eecf35f into main Jan 5, 2023
@alexandreLamarre alexandreLamarre deleted the cortex-rules branch January 5, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeranda joshmeranda joshmeranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandreLamarre @joshmeranda